New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: accept transfer connections in HandshakeListener #2196

Open

paolobettelini opened this issue Jun 16, 2024 · 1 comment

paolobettelini commented Jun 16, 2024

Minestom does not accept connections resulting from transfers packets. Currently, an UnsupportedOperationException is thrown

Minestom/src/main/java/net/minestom/server/listener/preplay/HandshakeListener.java

Line 118 in 8736fc4

 throw new UnsupportedOperationException("Transfer intent is not supported in HandshakeListener"); 

The text was updated successfully, but these errors were encountered:

ajh123 commented Jul 13, 2024

Instead of accepting all transfer connections maybe an event could be queued that will:

if not cancelled allow the transfer
if cancelled stop the transfer

This will allow developers to have a greater control of when a transfer is allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment