chore: use #[allow(dead_code)] in forc projects (FuelLabs#991)

Mey4am · Jun 9, 2023 · 09ebbef · 09ebbef
1 parent f41dd3a
commit 09ebbef
Show file tree

Hide file tree

Showing 51 changed files with 171 additions and 114 deletions.
diff --git a/packages/fuels/tests/bindings.rs b/packages/fuels/tests/bindings.rs
@@ -32,7 32,7 @@ async fn compile_bindings_from_contract_file() {
 
  let call_handler = simple_contract_instance
  .methods()
- .takes_ints_returns_bool(42);
  .takes_int_returns_bool(42);
 
  let encoded_args = call_handler.contract_call.encoded_args.resolve(0);
  let encoded = format!(
@@ -41,7 41,7 @@ async fn compile_bindings_from_contract_file() {
  hex::encode(encoded_args)
  );
 
- assert_eq!("000000009593586c000000000000002a", encoded);
  assert_eq!("000000005f68ee3d000000000000002a", encoded);
 }
 
 #[tokio::test]

diff --git a/packages/fuels/tests/bindings/sharing_types/contract_a/src/main.sw b/packages/fuels/tests/bindings/sharing_types/contract_a/src/main.sw
@@ -9,6 9,7 @@ struct StructSameNameButDifferentInternals {
  a: u32,
 }
 
 #[allow(dead_code)]
 enum EnumSameNameButDifferentInternals {
  a: u32,
 }

diff --git a/packages/fuels/tests/bindings/sharing_types/contract_b/src/main.sw b/packages/fuels/tests/bindings/sharing_types/contract_b/src/main.sw
@@ -9,6 9,7 @@ struct StructSameNameButDifferentInternals {
  a: [u64; 1],
 }
 
 #[allow(dead_code)]
 enum EnumSameNameButDifferentInternals {
  a: [u64; 1],
 }

diff --git a/packages/fuels/tests/bindings/sharing_types/shared_lib/src/lib.sw b/packages/fuels/tests/bindings/sharing_types/shared_lib/src/lib.sw
@@ -9,6 9,7 @@ pub struct SharedStruct2<K> {
  b: SharedStruct1<K>,
 }
 
 #[allow(dead_code)]
 pub enum SharedEnum<L> {
  a: u64,
  b: SharedStruct2<L>,

diff --git a/packages/fuels/tests/bindings/simple_contract/src/main.sw b/packages/fuels/tests/bindings/simple_contract/src/main.sw
@@ -1,11 1,11 @@
 contract;
 
 abi MyContract {
- fn takes_ints_returns_bool(only_argument: u32) -> bool;
  fn takes_int_returns_bool(arg: u32) -> bool;
 }
 
 impl MyContract for Contract {
- fn takes_ints_returns_bool(only_argument: u32) -> bool {
- true
  fn takes_int_returns_bool(arg: u32) -> bool {
  arg == 32u32
  }
 }
diff --git a/packages/fuels/tests/bindings/type_paths/src/main.sw b/packages/fuels/tests/bindings/type_paths/src/main.sw
@@ -11,7 11,7 @@ abi MyContract {
 }
 
 impl MyContract for Contract {
- fn test_function(arg: AWrapper) -> VeryCommonNameStruct {
  fn test_function(_arg: AWrapper) -> VeryCommonNameStruct {
  VeryCommonNameStruct { field_a: 10u32 }
  }
 }
diff --git a/packages/fuels/tests/contracts.rs b/packages/fuels/tests/contracts.rs
@@ -29,7 29,7 @@ async fn test_multiple_args() -> Result<()> {
  let contract_methods = contract_instance.methods();
  let response = contract_methods.get(5, 6).call().await?;
 
- assert_eq!(response.value, 5);
  assert_eq!(response.value, 11);
 
  let t = MyType { x: 5, y: 6 };
  let response = contract_methods.get_alt(t.clone()).call().await?;
@@ -162,11 162,11 @@ async fn test_multiple_read_calls() -> Result<()> {
  // Use "simulate" because the methods don't actually run a transaction, but just a dry-run
  // We can notice here that, thanks to this, we don't generate a TransactionId collision,
  // even if the transactions are theoretically the same.
- let stored = contract_methods.read(0).simulate().await?;
  let stored = contract_methods.read().simulate().await?;
 
  assert_eq!(stored.value, 42);
 
- let stored = contract_methods.read(0).simulate().await?;
  let stored = contract_methods.read().simulate().await?;
 
  assert_eq!(stored.value, 42);
  Ok(())
@@ -1001,7 1001,7 @@ async fn test_output_variable_contract_id_estimation_multicall() -> Result<()> {
  .call::<(u64, u64, u64, u64)>()
  .await?;
 
- assert_eq!(call_response.value, (43, 43, 43, 5));
  assert_eq!(call_response.value, (43, 43, 43, 11));
 
  Ok(())
 }
@@ -1043,7 1043,7 @@ async fn test_contract_call_with_non_default_max_input() -> Result<()> {
 
  let response = contract_instance.methods().get(5, 6).call().await?;
 
- assert_eq!(response.value, 5);
  assert_eq!(response.value, 11);
 
  Ok(())
 }
@@ -1101,7 1101,7 @@ async fn test_add_custom_assets() -> Result<()> {
  .call()
  .await?;
 
- assert_eq!(response.value, 5);
  assert_eq!(response.value, 11);
 
  let balance_asset_1 = wallet_1.get_asset_balance(&asset_id_1).await?;
  let balance_asset_2 = wallet_1.get_asset_balance(&asset_id_2).await?;

diff --git a/packages/fuels/tests/contracts/asserts/src/main.sw b/packages/fuels/tests/contracts/asserts/src/main.sw
@@ -5,6 5,7 @@ struct TestStruct {
  field_2: u64,
 }
 
 #[allow(dead_code)]
 enum TestEnum {
  VariantOne: (),
  VariantTwo: (),

diff --git a/packages/fuels/tests/contracts/configurables/src/main.sw b/packages/fuels/tests/contracts/configurables/src/main.sw
@@ -1,5 1,6 @@
 contract;
 
 #[allow(dead_code)]
 enum EnumWithGeneric<D> {
  VariantOne: D,
  VariantTwo: (),

diff --git a/packages/fuels/tests/contracts/contract_test/src/main.sw b/packages/fuels/tests/contracts/contract_test/src/main.sw
@@ -8,10 8,12 @@ struct MyType {
  y: u64,
 }
 
 #[allow(dead_code)]
 struct Person {
  name: str[4],
 }
 
 #[allow(dead_code)]
 enum State {
  A: (),
  B: (),
@@ -107,7 109,7 @@ impl TestContract for Contract {
  }
 
  fn get(x: u64, y: u64) -> u64 {
- x
  x y
  }
 
  fn get_alt(t: MyType) -> MyType {

diff --git a/packages/fuels/tests/contracts/large_return_data/src/main.sw b/packages/fuels/tests/contracts/large_return_data/src/main.sw
@@ -35,18 35,18 @@ impl TestContract for Contract {
  }
 
  fn get_small_struct() -> SmallStruct {
- SmallStruct { foo: 100 }
  SmallStruct { foo: 100u32 }
  }
 
  fn get_large_struct() -> LargeStruct {
  LargeStruct {
- foo: 12,
- bar: 42,
  foo: 12u8,
  bar: 42u8,
  }
  }
 
  fn get_large_array() -> [u32; 2] {
- let x: [u32; 2] = [1, 2];
  let x: [u32; 2] = [1u32, 2u32];
  x
  }
 

diff --git a/packages/fuels/tests/contracts/lib_contract_caller/src/main.sw b/packages/fuels/tests/contracts/lib_contract_caller/src/main.sw
@@ -25,12 25,12 @@ impl ContractCaller for Contract {
  let contract_instance = abi(LibContract, contract_id.into());
  let contract_instance2 = abi(LibContract, contract_id2.into());
 
- contract_instance.increment(value) contract_instance.increment(value)
  contract_instance.increment(value) contract_instance2.increment(value)
  }
 
  fn increment_from_contract_then_mint(contract_id: ContractId, amount: u64, address: Address) {
  let contract_instance = abi(LibContract, contract_id.into());
- let response = contract_instance.increment(42);
  let _ = contract_instance.increment(42);
 
  mint_to_address(amount, address);
  }

diff --git a/packages/fuels/tests/contracts/multiple_read_calls/src/main.sw b/packages/fuels/tests/contracts/multiple_read_calls/src/main.sw
@@ -6,7 6,7 @@ abi MyContract {
  #[storage(write)]
  fn store(input: u64);
  #[storage(read)]
- fn read(input: u64) -> u64;
  fn read() -> u64;
 }
 
 const COUNTER_KEY = 0x0000000000000000000000000000000000000000000000000000000000000000;
@@ -18,8 18,7 @@ impl MyContract for Contract {
  }
 
  #[storage(read)]
- fn read(input: u64) -> u64 {
- let v = read::<u64>(COUNTER_KEY, 0).unwrap_or(0);
- v
  fn read() -> u64 {
  read::<u64>(COUNTER_KEY, 0).unwrap_or(0)
  }
 }
diff --git a/packages/fuels/tests/contracts/require/src/main.sw b/packages/fuels/tests/contracts/require/src/main.sw
@@ -2,16 2,19 @@ contract;
 
 use std::logging::log;
 
 #[allow(dead_code)]
 enum EnumWithGeneric<D> {
  VariantOne: D,
  VariantTwo: (),
 }
 
 #[allow(dead_code)]
 struct StructWithNestedGeneric<D> {
  field_1: D,
  field_2: u64,
 }
 
 #[allow(dead_code)]
 struct StructDeeplyNestedGeneric<D> {
  field_1: D,
  field_2: u64,

diff --git a/packages/fuels/tests/contracts/token_ops/src/main.sw b/packages/fuels/tests/contracts/token_ops/src/main.sw
@@ -50,9 50,9 @@ impl TestFuelCoin for Contract {
 
  fn send_message(recipient: b256, coins: u64) {
  let mut data = Bytes::new();
- data.push(1);
- data.push(2);
- data.push(3);
  data.push(1u8);
  data.push(2u8);
  data.push(3u8);
 
  send_message(recipient, data, coins);
  }

diff --git a/packages/fuels/tests/logs/contract_logs/src/main.sw b/packages/fuels/tests/logs/contract_logs/src/main.sw
@@ -3,32 3,38 @@ contract;
 use std::logging::log;
 use contract_logs::ContractLogs;
 
 #[allow(dead_code)]
 struct TestStruct {
  field_1: bool,
  field_2: b256,
  field_3: u64,
 }
 
 #[allow(dead_code)]
 enum TestEnum {
  VariantOne: (),
  VariantTwo: (),
 }
 
 #[allow(dead_code)]
 struct StructWithGeneric<D> {
  field_1: D,
  field_2: u64,
 }
 
 #[allow(dead_code)]
 enum EnumWithGeneric<D> {
  VariantOne: D,
  VariantTwo: (),
 }
 
 #[allow(dead_code)]
 struct StructWithNestedGeneric<D> {
  field_1: D,
  field_2: u64,
 }
 
 #[allow(dead_code)]
 struct StructDeeplyNestedGeneric<D> {
  field_1: D,
  field_2: u64,

diff --git a/packages/fuels/tests/logs/script_logs/src/main.sw b/packages/fuels/tests/logs/script_logs/src/main.sw
@@ -2,32 2,38 @@ script;
 
 use std::logging::log;
 
 #[allow(dead_code)]
 struct TestStruct {
  field_1: bool,
  field_2: b256,
  field_3: u64,
 }
 
 #[allow(dead_code)]
 enum TestEnum {
  VariantOne: (),
  VariantTwo: (),
 }
 
 #[allow(dead_code)]
 struct StructWithGeneric<D> {
  field_1: D,
  field_2: u64,
 }
 
 #[allow(dead_code)]
 enum EnumWithGeneric<D> {
  VariantOne: D,
  VariantTwo: (),
 }
 
 #[allow(dead_code)]
 struct StructWithNestedGeneric<D> {
  field_1: D,
  field_2: u64,
 }
 
 #[allow(dead_code)]
 struct StructDeeplyNestedGeneric<D> {
  field_1: D,
  field_2: u64,

diff --git a/packages/fuels/tests/predicates.rs b/packages/fuels/tests/predicates.rs
@@ -240,7 240,7 @@ async fn pay_with_predicate_vector_data() -> Result<()> {
  )
  );
 
- let predicate_data = MyPredicateEncoder::encode_data(2, 4, vec![2, 4, 42]);
  let predicate_data = MyPredicateEncoder::encode_data(12, 30, vec![2, 4, 42]);
 
  let mut predicate: Predicate = Predicate::load_from(
  "tests/types/predicates/predicate_vector/out/debug/predicate_vector.bin",
@@ -289,7 289,7 @@ async fn predicate_contract_transfer() -> Result<()> {
  "packages/fuels/tests/types/predicates/predicate_vector/out/debug/predicate_vector-abi.json"
  ));
 
- let predicate_data = MyPredicateEncoder::encode_data(2, 4, vec![2, 4, 42]);
  let predicate_data = MyPredicateEncoder::encode_data(2, 40, vec![2, 4, 42]);
 
  let mut predicate: Predicate = Predicate::load_from(
  "tests/types/predicates/predicate_vector/out/debug/predicate_vector.bin",
@@ -353,7 353,7 @@ async fn predicate_transfer_to_base_layer() -> Result<()> {
  "packages/fuels/tests/types/predicates/predicate_vector/out/debug/predicate_vector-abi.json"
  ));
 
- let predicate_data = MyPredicateEncoder::encode_data(2, 4, vec![2, 4, 42]);
  let predicate_data = MyPredicateEncoder::encode_data(22, 20, vec![2, 4, 42]);
 
  let mut predicate: Predicate = Predicate::load_from(
  "tests/types/predicates/predicate_vector/out/debug/predicate_vector.bin",
@@ -400,7 400,7 @@ async fn predicate_transfer_with_signed_resources() -> Result<()> {
  "packages/fuels/tests/types/predicates/predicate_vector/out/debug/predicate_vector-abi.json"
  ));
 
- let predicate_data = MyPredicateEncoder::encode_data(2, 4, vec![2, 4, 42]);
  let predicate_data = MyPredicateEncoder::encode_data(2, 40, vec![2, 4, 42]);
 
  let mut predicate: Predicate = Predicate::load_from(
  "tests/types/predicates/predicate_vector/out/debug/predicate_vector.bin",
@@ -486,7 486,7 @@ async fn contract_tx_and_call_params_with_predicate() -> Result<()> {
  )
  );
 
- let predicate_data = MyPredicateEncoder::encode_data(2, 4, vec![2, 4, 42]);
  let predicate_data = MyPredicateEncoder::encode_data(22, 20, vec![2, 4, 42]);
 
  let mut predicate: Predicate = Predicate::load_from(
  "tests/types/predicates/predicate_vector/out/debug/predicate_vector.bin",
@@ -563,7 563,7 @@ async fn diff_asset_predicate_payment() -> Result<()> {
  )
  );
 
- let predicate_data = MyPredicateEncoder::encode_data(2, 4, vec![2, 4, 42]);
  let predicate_data = MyPredicateEncoder::encode_data(28, 14, vec![2, 4, 42]);
 
  let mut predicate: Predicate = Predicate::load_from(
  "tests/types/predicates/predicate_vector/out/debug/predicate_vector.bin",

diff --git a/packages/fuels/tests/predicates/basic_predicate/src/main.sw b/packages/fuels/tests/predicates/basic_predicate/src/main.sw
@@ -1,5 1,5 @@
 predicate;
 
 fn main(a: u32, b: u64) -> bool {
- a == b
  b == a
 }
diff --git a/packages/fuels/tests/predicates/predicate_configurables/src/main.sw b/packages/fuels/tests/predicates/predicate_configurables/src/main.sw
@@ -17,6 17,7 @@ impl Eq for EnumWithGeneric<bool> {
 }
 
 // ANCHOR: predicate_configurables
 #[allow(dead_code)]
 enum EnumWithGeneric<D> {
  VariantOne: D,
  VariantTwo: (),