Update text, adjust some small styling issues, fill out Readme #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfuchs
approved these changes
Oct 16, 2017
components/Track.js
Outdated
| @@ -66,14 66,14 @@ class Track extends React.Component<Props> { | |||
| </table> | |||
| {currentMilestone ? ( | |||
| <div style={{flex: 1}}> | |||
| <p>{currentMilestone.summary}</p> | |||
| <h4>Example behaviors:</h4> | |||
| <h3>{currentMilestone.summary}</h3> | |||
There was a problem hiding this comment.
That doesn't seem correct, semantics-wise.
| display: block; | ||
| border-bottom: 2px solid #fff; |
There was a problem hiding this comment.
later we can talk about less janky ways to do this :-)
There was a problem hiding this comment.
yeah, i had a feeling this was weird.
| display: block; | ||
| border-bottom: 2px solid #fff; |
There was a problem hiding this comment.
later we can talk about less janky ways to do this :-)
majelbstoat
force-pushed
the
jamie/tweaks
branch
from
5d8b01d to
32fa9c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @jfuchs, @emmazhou,
Please review the following commits I made in branch 'jamie/tweaks'.
5d8b01d7f59e86e26e02e190a021b4ed5f8831c5 (2017-10-16 10:11:29 -0700)
Update text, adjust some small styling issues, fill out Readme
R=@jfuchs
R=@emmazhou
MANUAL TESTING=not manually tested