Destoy files when destroying post #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @MaxLeiter on Vercel. @MaxLeiter first needs to authorize it. |
|
I'll try and understand the whole |
|
Great catch, thank you 🙏 For what its worth, I originally envisioned supporting multiple post authors, hence the through table. But now I'm not sure that's necessary, so if it simplifies your work feel free to make it a one-to-many |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51 though we should consider adding a overarching transaction over the whole deletion 😸.
The deletion here:
Drift/server/src/routes/posts.ts
Lines 312 to 313 in 6a6a2a3
was ok, but
fileskey was never set.