Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display after saving and more syntax highlighting #115

Open
XeroxDev opened this issue May 9, 2022 · 2 comments
Open

Display after saving and more syntax highlighting #115

XeroxDev opened this issue May 9, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@XeroxDev
Copy link

XeroxDev commented May 9, 2022

Describe the bug
I noticed that uploaded files are no longer displayed correctly. No syntax highlighting and no more new lines.

I also noticed the syntax highlighting isn't that good overall. Some languages are not supported entirely (CSharp) and others have just two colors (js, json). Would be nice if the syntax highlighting is like in github.

To Reproduce
Steps to reproduce the behavior:

  1. Upload a file (I've tested it with a simple hello world c# file)
  2. save it

Expected behavior
Preview should display it correctly. (Syntax highlighting, new lines and so on)

Screenshots
CSharp File (Preview)
image
CSharpFile (RAW)
image
Json File (Preview)
image
Json File (RAW)
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser firefox
  • Version 100.0

Additional context
Code to copy

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace ConsoleApp1
{
    class Program
    {
        static void Main(string[] args)
        {
            Console.WriteLine("Hello, world!");
            Console.ReadLine();
        }
    }
}
{
  "Hello": "World",
  "Integer": 123.45,
  "BoolTrue": true,
  "BoolFalse": false
}
@XeroxDev XeroxDev added the bug Something isn't working label May 9, 2022
@XeroxDev
Copy link
Author

bump

@MaxLeiter
Copy link
Owner

I'm currently in the process of refactoring Drift and improved highlighting is one of my goals. It's an easy fix -- the current code strips out styles because I intended to add them on the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants