Add -m64 to gcc by default on illumos #721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WorkDoneProgress to represent WorkDoneProgressBegin/WorkDoneProgressReport/WorkDoneProgressEnd.
…n is not used Note: `exact_match` should be false if the entry is an synthetic one, instead of an explicit entry in compile_commands.json
…of clang::driver::Driver
GCC on illumos generates 32-bit object files by default to maintain backward compatibility, despite 32-bit platforms are no longer supported. This may cause link errors, since most distros seem to supply 64-bit LLVM in their repositories (verified on OpenIndiana and OmniOS). This commit adds an ILLUMOS_USE_M64 option, which is turned on by default, to instruct gcc on illumos to generate 64-bit object files, as this is usually the desired behaviour.
|
Note: This change added a illumos-specific option (ILLUMOS_USE_M64), which probably should be documented in wiki if this PR gets merged. |
MaskRay
force-pushed
the
master
branch
3 times, most recently
from
ee29996
to
feb153a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC on illumos generates 32-bit object files by default to maintain
backward compatibility, despite 32-bit platforms are no longer
supported. This may cause link errors, since most distros seem to supply
64-bit LLVM in their repositories (verified on OpenIndiana and OmniOS).
This commit adds an ILLUMOS_USE_M64 option, which is turned on by
default, to instruct gcc on illumos to generate 64-bit object files, as
this is usually the desired behaviour.