Allow relative path for directory #704
Conversation
…of clang::driver::Driver
directory in compiler_commands.json If the value is relative we resolve it from root
|
Linked issue: directory value as relative path in compile_commands.json #703 |
|
Currently |
|
Assuming that the current working directory refers to the workspace directory. I tried all possible combinations but it didn't work. In CCLS logs, I can see that the files are resolved with relative paths only. |
|
Hi @MaskRay did you get time to check this? |
|
I believe the problem is that your client does not chdir to the project root. Which client do you use? |
|
I use VSCode |
|
You were right @MaskRay . VSCode does not chdir to the project root It's always pointing to my home directory. But since ccls is given a project path to initialize, won't be it good to chdir to the project path during initialization? |
|
Need to be looked into from another angle |
directory in compiler_commands.json
If the value is relative we resolve it from the root
This will help in VS Code integration. We open the root folder in VS Code and the directory value can be specified as related to the root folder. Thus the compile_commnads.json can be committed to the code repository rather than having to build it every time code is pulled.