set background thread priority on index threads #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is not very clear what |
Moved discussion to #536 as these are similar. |
MaskRay
reviewed
Dec 5, 2019
src/messages/initialize.cc
Outdated
| @@ -255,6 255,9 @@ void *indexer(void *arg_) { | |||
| delete arg; | |||
| std::string name = "indexer" std::to_string(idx); | |||
| set_thread_name(name.c_str()); | |||
| #if defined(LLVM_ENABLE_THREADS) && LLVM_VERSION_MAJOR >= 9 | |||
There was a problem hiding this comment.
#if LLVM_ENABLE_THREADS && LLVM_VERSION_MAJOR >= 9
llvm/include/llvm/Config/llvm-config.h.cmake says
says #cmakedefine01 LLVM_ENABLE_THREADS
MaskRay
force-pushed
the
batch_priority
branch
from
d3bc255
to
64e3e8f
Compare
MaskRay
pushed a commit
that referenced
this pull request
Apr 22, 2020
MaskRay
pushed a commit
that referenced
this pull request
Apr 22, 2020
MaskRay
pushed a commit
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I created #537 which uses the Linux-specific
SCHED_BATCH, but then I noticed that LLVM has a platform-agnostic way of doing this that works on Windows, macOS, etc. Note that the LLVM implementation usesSCHED_IDLEon Linux which is much more extreme thanSCHED_BATCH, but probably still OK for the indexer 🤷