Wrong diagnostics on macOS w/ clang10 #622

flanggut · 2020-04-27T11:34:51Z

Observed behavior

compile_commands.json

[
  {
    "directory": "/Users/flanggut/tmp/ccls",
    "file": "/Users/flanggut/tmp/ccls/main.cpp",
    "arguments": [
      "/usr/local/opt/llvm/bin/clang  ",
      "-std=c  17",
      "-isystem /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include",
      "-isystem /Library/Developer/CommandLineTools/usr/lib/clang/11.0.3/include/",
      "-I.",
      "main.cpp"
    ]
  }
]

main.cpp

#include <chrono>
auto clk() {
  return std::chrono::high_resolution_clock::now();
}
int main(int /*argc*/, char** /*argv*/) {
  auto clk0 = clk();
}

ccls --index=. -v=2
Correctly identifies and and indexes all headers.

/usr/local/opt/llvm/bin/clang   --driver-mode=g   -std=c  17 -isystem /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -isystem /Library/Developer/CommandLineTools/usr/lib/clang/11.0.3/include/ -I. main.cpp

File compiles without issues.

In my editor ccls claims that <chrono> include cannot be found under ./chrono, note that the error is always shown for the include path -I., if I change that to -I.. the error will show that ../chrono cannot be found.

This only happens since clang/llvm10 and does not happen if I compile ccls against clang/llvm9.

Expected behavior

No diagnostics should be shown in an editor.

Steps to reproduce

brew install ccls (recently updated to use llvm10)
Open file in editor w/ ccls as language server

System information

ccls version (git describe --tags --long): brew info ccls
clang version: clang version 10.0.0
OS: x86_64-apple-darwin19.4.0
Editor: nvim / vscode
Language client (and version): coc.nvim / vscode-ccls

The text was updated successfully, but these errors were encountered:

thinkiny · 2020-04-27T12:21:44Z

same problem

sunbubble · 2020-04-27T18:01:21Z

Same, and I can confirm that I'm setting the resourcesDir in my ccls initializer options. Check #611

For me this also occurs since the latest homebrew update.

flanggut · 2020-05-03T14:08:01Z

It might be a weird interaction in the homebrew version of things. I managed to build a version using the official llvm release that runs without issues. If anyone needs a workaround for now:

Download the official llvm release from https://releases.llvm.org/download.html#10.0.0 (direct link) and unpack.
Manually install ccls HEAD version in homebrew

brew uninstall ccls
brew install ccls --HEAD -i

this will open a terminal in a temp directory that allows you to "manually" compile and install ccls within homebrew. In there I ran

cmake -H. -BRelease -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=/Users/flanggut/local/clang llvm-10.0.0-x86_64-apple-darwin/ -DCMAKE_INSTALL_PREFIX=/usr/local/Cellar/ccls/HEAD-c5acf62 -DUSE_SYSTEM_RAPIDJSON=OFF -DCMAKE_CXX_COMPILER=/Users/flanggut/local/clang llvm-10.0.0-x86_64-apple-darwin/bin/clang

pointing cmake directly to the official llvm release (make sure the install prefix points to the right directory, homebrew will tell you where it expects the installed files). Then you just do

cd Release
make install
exit

And homebrew automatically links ccls if you've installed it to the right directory.

sunbubble · 2020-05-03T14:14:34Z

@flanggut, sorry if this is a stupid question, but did you try this with the homebrew version of llvm?

flanggut · 2020-05-03T14:16:20Z

That was the first thing I tried, unfortunately it didn't work for me :/

sunbubble · 2020-05-03T14:18:16Z

Weird. Could there be a problem with the packaging of llvm for homebrew?

flanggut · 2020-05-03T14:23:48Z

Maybe, I haven't looked into how the homebrew version of llvm is built.

T-Skinner · 2020-05-11T06:51:40Z

I'm having a similar issue. Running MacOS Catalina with Apple clang version 11.0.3

neiljohari · 2020-05-22T00:41:13Z

@flanggut Thank you! This workaround resolves my issue in #191 (comment)

I believe you are right that this is a version issue with homebrew. The problems I experienced happened after no changes to configuration, only version upgrades.

I'm not even sure what a proper fix for this type of issue looks like, it genuinely might be an issue with homebrew llvm

cweagans · 2020-05-28T21:23:40Z

I think this is related -- I'm having a similar issue finding Arduino.h (installed via Platform.io):

I have #include <Arduino.h> in my code, -I/Users/cweagans/.platformio/packages/framework-arduino-avr/cores/arduino in .ccls in my project root, and Arduino.h definitely exists at /Users/cweagans/.platformio/packages/framework-arduino-avr/cores/arduino/Arduino.h. ccls is telling me that it can't open /Users/cweagans/Code/shopctl/include/Arduino.h though.

I have not tried the workaround posted above, but I'll give it a go when I have some time.

brglng · 2020-06-07T05:30:56Z

Same issue here.

sprmn · 2020-06-08T21:17:34Z

@flanggut Thank you so much, been stuck on this for hours. Works like a charm!

However I had the problem mentioned here. clang was complaining about an invalid option -platform_version.

So I had to add -DCMAKE_CXX_FLAGS="-mlinker-version=450".

For people with similar problems: You can find your linker version via ld -v.

This oneliner should do the trick:

ld -v 2>&1 | head -n1 | awk -F "ld64-" '{print int($2)}'

krishnakumarg1984 · 2020-07-09T16:58:56Z

Yup. Same issue here.

Confirmed on macOS cataline 10.15.5 and clang 11.0.3 with the HEAD version of ccls from homebrew.

madeddie · 2020-07-23T19:56:34Z

@cweagans what works for me is using the compile_commands.json db generated with pio run -t compiledb. I symlink it from its location to the project root.

dhoon-dev · 2020-07-29T17:48:51Z

Same issue..

@flanggut Thanks, only your solution works for me 👍

yushangakki · 2020-08-24T20:08:10Z

flanggut's solution works! In this case, whenever there is a new version of ccls, do I have to recompile everything? Thanks!

HealsCodes · 2020-11-27T17:46:46Z

I tried most of the workarounds listed in the various issues linked here and cross-linked to each-other.
The one thing that did it for me was to have this .ccls alongside my compile_commands.json:

%compile_commands.json
-isystem/Library/Developer/CommandLineTools/usr/include/
-isystem/Library/Developer/CommandLineTools/usr/include/c  /v1

The part that did it for me was to remove all spaces between '-isystem' and the path.
Writing it like -isystem /Library/Deveolper/CommandLineTools/usr/include/ causes the same error.

madscientist · 2020-11-27T19:23:40Z

I am no expert on either MacOS or on the .ccls file format: I don't use the former and struggle to understand the details of the latter (I wish it could be replaced with a more standard format such as JSON or similar).

However, I'm pretty sure that the .ccls file requires each argument to be on its own line in the file. If you write this:

-isystem /Library/Developer/CommandLineTools/usr/include/

in .ccls, or if you add this to your compile_commands.json file:

      "-isystem /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include",

that is the same thing as passing arguments like this to clang:

  clang ... '-isystem /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include' ...

(note the quotes here). If you check the clang docs the format for the -isystem option is:

-isystem<directory>
Add directory to SYSTEM include search path

Basically, you're adding the directory /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include (including the leading space character!!!) as a system path. That can explain why these paths don't seem to have any effect: it's equivalent to the path ./ /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include and there is no directory ./ / (space) in your working directory.

You can either remove the space as @Shirk did, or you can put each argument on a separate line / in a separate argument. For .ccls it would be:

-isystem
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include

and for compile_commands.json it would be something like:

      "-isystem",
      "/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include",

madscientist · 2020-11-27T19:24:42Z

Note I can't explain why it works with some versions of clang and not with others: there may be two different issues that are being conflated, or else maybe clang's command line option parser changed to become more strict about whitespace.

neiljohari · 2021-01-11T21:35:11Z

Just wanted to provide an update: on macOS Big Sur 11.1, I finally have it working without needing @flanggut's solution (though that solution did save me for the last 9 months).

tan-wei · 2021-06-11T15:10:37Z

On MacOS Big Sur 11.4, I meet the similar issue. ccls complains that can't find <stdarg.h>. The core problem here IMO is the option -isysroot. ccls can't parse the search path here.

tan-wei · 2021-06-11T15:49:33Z

Ok, @flanggut 's method works for me:

brew uninstall ccls
brew install ccls --HEAD -i

A local compilation will work well.

eagomez2 · 2021-09-23T22:08:00Z

I am having the same issue on macOS Big Sur 11.6 but when I try @flanggut 's method I encounter the following error during the make install step:

make[2]: *** No rule to make target `/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk/usr/lib/libcurses.tbd', needed by `ccls'.  Stop.
make[2]: *** Waiting for unfinished jobs....
[ 97%] Building CXX object CMakeFiles/ccls.dir/src/messages/workspace.cc.o
make[1]: *** [CMakeFiles/ccls.dir/all] Error 2
make: *** [all] Error 2

I am using clang llvm-12.0.0-x86_64-apple-darwin because with earlier versions I get a bunch of errors during the compilation process. Any help is highly appreciated.

Edit:
I managed to solve it by following these steps. However, I still get the same issue while using ccls in my projects.

MaskRay · 2021-09-24T02:43:09Z

https://github.com/MaskRay/ccls/wiki/Build#macos this works for me on arm64 macOS.

#!/bin/sh
exec /opt/homebrew/bin/ccls --init='{"clang":{"extraArgs":[
  "-isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c  /v1",
  "-isystem/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/12.0.5/include",
  "-isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include",
  "-isystem/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include",
  "-isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks"
]}}' "$@"

eagomez2 · 2021-09-24T10:23:51Z

Hi,

I have an Intel machine with Big Sur and I am using ccls with coc.nvim, so I added the corresponding paths to coc-settings.json as follows:

{
    "languageserver": {
        "ccls": {
            "command": "ccls",
            "filetypes": ["c", "cpp", "objc", "objcpp"],
            "rootPatterns": [".ccls", "compile_commands.json", ".vim/", ".git/", ".hg/"],
            "initializationOptions": {
                "cache": {
                    "directory": "/tmp/ccls"
                },
                // see https://github.com/MaskRay/ccls/issues/191
                "clang": {
                    // from clang -v -fsyntax-only -x c   /dev/null
                    "extraArgs": [
                        "-isystem/usr/local/include",
                        "-isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c  /v1",
                        "-isystem/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/12.0.5/include",
                        "-isystem/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include",
                        "-isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include",
                        "-isystem/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks"
                    ],
                    //From clang -print-resource-dir
                    "resourceDir": "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/12.0.5"
                }
            }
        }
    }
}

More concretely, if I do ccls --index=. -v=2 I can see the paths are added, including /usr/local/include that is the one that concerns me, because inside it I have Eigen that cannot be found by ccls. If I add it using:

#include <Eigen/Dense>

I see fatal error: 'Eigen/Dense' file not found. However, if I compile the project it does so correctly and runs fine.

Here is also my compile_commands.json exported using -DCMAKE_EXPORT_COMPILE_COMMANDS where I can also see that both /usr/local/include and /usr/local/include/eigen3 are added.

[
{
  "directory": "/Users/eagomez/Desktop/project/build",
  "command": "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c    -I/usr/local/include -I/Users/eagomez/Desktop/project/source/include -isystem /usr/local/include/eigen3  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -std=gnu  2a -o CMakeFiles/CPPTest.dir/main.cpp.o -c /Users/eagomez/Desktop/project/source/main.cpp",
  "file": "/Users/eagomez/Desktop/project/source/main.cpp"
},
{
  "directory": "/Users/eagomez/Desktop/project/build",
  "command": "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c    -I/usr/local/include -I/Users/eagomez/Desktop/project/source/include -isystem /usr/local/include/eigen3  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -std=gnu  2a -o CMakeFiles/CPPTest.dir/include/ETL.cpp.o -c /Users/eagomez/Desktop/project/source/include/ETL.cpp",
  "file": "/Users/eagomez/Desktop/project/source/include/ETL.cpp"
}
]

Thanks for your help!

sunbubble mentioned this issue May 2, 2020

Standard library headers not recognised #629

Closed

neiljohari mentioned this issue May 22, 2020

ccls c header completion on osx #191

Closed

jaza-syed mentioned this issue Jun 10, 2020

Flycheck says iostream and local lib cannot be imported but LSP commands works as expected emacs-lsp/emacs-ccls#88

Closed

MaskRay mentioned this issue Jul 5, 2020

Cannot autocomplete in Mac OS #637

Closed

neiljohari mentioned this issue Oct 25, 2020

Some aliased types are reported as typedef int #396

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrong diagnostics on macOS w/ clang10 #622

Wrong diagnostics on macOS w/ clang10 #622

flanggut commented Apr 27, 2020 •

edited

Loading

thinkiny commented Apr 27, 2020

sunbubble commented Apr 27, 2020 •

edited

Loading

flanggut commented May 3, 2020

sunbubble commented May 3, 2020

flanggut commented May 3, 2020

sunbubble commented May 3, 2020

flanggut commented May 3, 2020

T-Skinner commented May 11, 2020

neiljohari commented May 22, 2020 •

edited

Loading

cweagans commented May 28, 2020

brglng commented Jun 7, 2020 •

edited

Loading

sprmn commented Jun 8, 2020

krishnakumarg1984 commented Jul 9, 2020 •

edited

Loading

madeddie commented Jul 23, 2020

dhoon-dev commented Jul 29, 2020

yushangakki commented Aug 24, 2020

HealsCodes commented Nov 27, 2020

madscientist commented Nov 27, 2020 •

edited

Loading

madscientist commented Nov 27, 2020

neiljohari commented Jan 11, 2021 •

edited

Loading

tan-wei commented Jun 11, 2021

tan-wei commented Jun 11, 2021

eagomez2 commented Sep 23, 2021 •

edited

Loading

MaskRay commented Sep 24, 2021

eagomez2 commented Sep 24, 2021 •

edited

Loading

Wrong diagnostics on macOS w/ clang10 #622

Wrong diagnostics on macOS w/ clang10 #622

Comments

flanggut commented Apr 27, 2020 • edited Loading

Observed behavior

Expected behavior

Steps to reproduce

System information

thinkiny commented Apr 27, 2020

sunbubble commented Apr 27, 2020 • edited Loading

flanggut commented May 3, 2020

sunbubble commented May 3, 2020

flanggut commented May 3, 2020

sunbubble commented May 3, 2020

flanggut commented May 3, 2020

T-Skinner commented May 11, 2020

neiljohari commented May 22, 2020 • edited Loading

cweagans commented May 28, 2020

brglng commented Jun 7, 2020 • edited Loading

sprmn commented Jun 8, 2020

krishnakumarg1984 commented Jul 9, 2020 • edited Loading

madeddie commented Jul 23, 2020

dhoon-dev commented Jul 29, 2020

yushangakki commented Aug 24, 2020

HealsCodes commented Nov 27, 2020

madscientist commented Nov 27, 2020 • edited Loading

madscientist commented Nov 27, 2020

neiljohari commented Jan 11, 2021 • edited Loading

tan-wei commented Jun 11, 2021

tan-wei commented Jun 11, 2021

eagomez2 commented Sep 23, 2021 • edited Loading

MaskRay commented Sep 24, 2021

eagomez2 commented Sep 24, 2021 • edited Loading

flanggut commented Apr 27, 2020 •

edited

Loading

sunbubble commented Apr 27, 2020 •

edited

Loading

neiljohari commented May 22, 2020 •

edited

Loading

brglng commented Jun 7, 2020 •

edited

Loading

krishnakumarg1984 commented Jul 9, 2020 •

edited

Loading

madscientist commented Nov 27, 2020 •

edited

Loading

neiljohari commented Jan 11, 2021 •

edited

Loading

eagomez2 commented Sep 23, 2021 •

edited

Loading

eagomez2 commented Sep 24, 2021 •

edited

Loading