Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom objectconfigurator position options #233

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

no3rdw
Copy link
Contributor

@no3rdw no3rdw commented Aug 10, 2023

I could find no way to customize the classes listed in the objectconfigurator custom tag. AFAIK, this custom tag is not an object that can be extended to a site- or theme-specific location. Similar options such as 'contentGridStyleMap' (a struct of classes that can be applied specifically to the 'Collection' module) are extended this way, allowing the default setting to be overridden in the contentRenderer.cfm.

Fixed related content advanced search by not passing entitytype - this is appended by the next function downstream
I could find no way to customize the classes listed in the objectconfigurator custom tag.  AFAIK, this custom tag is not an object that can be extended to a site- or theme-specific location.  Similar options such as 'contentGridStyleMap' (a struct of classes that can be applied specifically to the 'Collection' module) are extended this way, allowing the default setting to be overridden in the contentRenderer.cfm.
@no3rdw
Copy link
Contributor Author

no3rdw commented Aug 10, 2023

I am terrible at GitHub and can't figure out how to exclude my already-submitted pull request related to fixing the related content advanced search.

@guustnieuwenhuis guustnieuwenhuis changed the base branch from main to release/7.4.4 August 25, 2023 07:55
Copy link
Contributor

@guustnieuwenhuis guustnieuwenhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice new feature!
I'll add a separate commit with a commented out default setting to the contentRenderer template in the core (as documentation for this setting).

@guustnieuwenhuis guustnieuwenhuis merged commit f2c6c0f into MasaCMS:release/7.4.4 Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants