Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDEV-35022 Fix Overuse of big stackvariables results inside InnoDB & mariabackup #3555

Open
wants to merge 1 commit into
base: 10.6
Choose a base branch
from
Open

MDEV-35022 Fix Overuse of big stackvariables results inside InnoDB & mariabackup #3555

wants to merge 1 commit into from

Conversation

Thirunarayanan
Copy link
Member

  • The Jira issue number for this PR is: MDEV-35022

Description

  • This patch removes the PRAGMA_DISABLE_CHECK_STACK_FRAME usage inside innodb, mariabackup and also made the large variable into thread_local storage or use the heap memory

Release Notes

Made big stack variable into thread local storage and make use of heap memory.

How can this PR be tested?

cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS=-Wstack-usage=8192 -DMYSQL_MAINTAINER_MODE && make -j4

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Thirunarayanan
MDEV-35022 Fix Overuse of big stackvariables results inside InnoDB & …
f3399c6 
…Mariabackup

- This patch removes the PRAGMA_DISABLE_CHECK_STACK_FRAME usage
inside innodb, mariabackup and also made the large variable
into thread_local storage or use the heap memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-m dr-m Awaiting requested review from dr-m

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thirunarayanan @CLAassistant