MDEV-27037 mysqlbinlog emits a warning when reaching EOF before stop-condition #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DaveGosselin-MariaDB
force-pushed
the
10.5-mdev-27037-stop-pos-warning
branch
2 times, most recently
from
dfccd95
to
269b3d7
Compare
bnestere
requested changes
Jul 15, 2024
DaveGosselin-MariaDB
force-pushed
the
10.5-mdev-27037-stop-pos-warning
branch
from
269b3d7
to
d70f875
Compare
bnestere
requested changes
Jul 17, 2024
There was a problem hiding this comment.
Thanks @DaveGosselin-MariaDB for a quick update, the patch is coming along nicely 😄. I left a few more notes.
mysql-test/suite/binlog/t/binlog_mysqlbinlog_warn_stop_position.test
Outdated
Show resolved
Hide resolved
bnestere
reviewed
Jul 17, 2024
DaveGosselin-MariaDB
force-pushed
the
10.5-mdev-27037-stop-pos-warning
branch
from
d70f875
to
3e83ea5
Compare
|
I need to investigate why some of the builders failed on my new test for the second commit while others did not. |
DaveGosselin-MariaDB
force-pushed
the
10.5-mdev-27037-stop-pos-warning
branch
3 times, most recently
from
266a32d
to
aa1207f
Compare
bnestere
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Looks good, thank you @DaveGosselin-MariaDB ! I just had one last minor thought for cleanup.
|
|
||
| --source include/have_binlog_format_statement.inc | ||
|
|
||
| --let assert_file= $MYSQLTEST_VARDIR/tmp/warn_pos_test_file.out |
There was a problem hiding this comment.
I think the name assert_file makes it seem like the file itself has content that will be validated, esp hinting towards assert_grep.inc. But it is actually ignored. I think the name should set the expectation that the file is ignored.
There was a problem hiding this comment.
Thanks, I made that change and added --echo commands that reflect what's --exec'd (to have parity with the ...warn_stop_position.test file).
…condition Emit a warning in the event that we finished processing input files before reaching the boundary indicated by --stop-position.
…datetime Emit a warning in the event that we finished processing input files before reaching the boundary indicated by --stop-datetime.
DaveGosselin-MariaDB
force-pushed
the
10.5-mdev-27037-stop-pos-warning
branch
from
aa1207f
to
23489ef
Compare
ParadoxV5
added a commit
that referenced
this pull request
Oct 29, 2024
…e stop-condition * `binlog_mysqlbinlog_warn_stop_position`: Name the temporary output redirect as ignored to match `binlog_mysqlbinlog_warn_stop_datetime` * #3400 (comment) * `binlog_mysqlbinlog_warn_stop_datetime`: Remove duplicate case
ParadoxV5
added a commit
that referenced
this pull request
Oct 29, 2024
This commit adds warnings for `--stop-position` GTIDs that were not reached at EOF, mainly as a follow-up to MDEV-27037 Mysqlbinlog should output a warning if EOF is found before its stop condition (#3400). `--stop-position` warnings inform possible mistakes in the input, especially for progress reporting of scripts/wrappers. MDEV-34614 enchances MDEV-27037 with individualized GTID validation, for GTID range selection weren’t in all versions that MDEV-27037 targeted. Unlike #3400, `Binlog_gtid_state_validator` provides the code behind this feature rather than `mysqlbinlog` itself. Motivations behind this decision are: * For a patch that’ll apply on older versions, this choice yields a smaller change footprint. * `Binlog_gtid_state_validator` is already prompting unreached *`--start-position`s* for `--gtid-strict-mode`/`-vvv`.
ParadoxV5
added a commit
that referenced
this pull request
Oct 29, 2024
This commit adds warnings for `--stop-position` GTIDs that were not reached at EOF, mainly as a follow-up to MDEV-27037 Mysqlbinlog should output a warning if EOF is found before its stop condition (#3400). `--stop-position` warnings inform possible mistakes in the input, especially for progress reporting of scripts/wrappers. MDEV-34614 enhances MDEV-27037 with individualized GTID validation, for GTID range selection weren’t in all versions that MDEV-27037 targeted. Unlike #3400, `Binlog_gtid_state_validator` provides the code behind this feature rather than `mysqlbinlog` itself. Motivations behind this decision are: * For a patch that’ll apply on older versions, this choice yields a smaller change footprint. * `Binlog_gtid_state_validator` is already prompting unreached *`--start-position`s* for `--gtid-strict-mode`/`-vvv`.
4 tasks
ParadoxV5
added a commit
that referenced
this pull request
Oct 31, 2024
This commit adds warnings for `--stop-position` GTIDs that were not reached at EOF, mainly as a follow-up to MDEV-27037 Mysqlbinlog should output a warning if EOF is found before its stop condition (#3400). `--stop-position` warnings inform possible mistakes in the input, especially for progress reporting of scripts/wrappers. MDEV-34614 enhances MDEV-27037 with individualized GTID validation, for GTID range selection weren’t in all versions that MDEV-27037 targeted. Unlike #3400, `Binlog_gtid_state_validator` provides the code behind this feature rather than `mysqlbinlog` itself. Motivations behind this decision are: * For a patch that’ll apply on older versions, this choice yields a smaller change footprint. * `Binlog_gtid_state_validator` is already prompting unreached *`--start-position`s* for `--gtid-strict-mode`/`-vvv`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit warnings if finished processing input files before reaching the boundary conditions indicated by either
--stop-positionor--stop-datetime.