Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue: #451
What does this Pull Request do?
Adds a metadata manipulator that appends an element containing a UUID to metadata XML created by the Templated metadata parser.
What's new?
A new metadata manipulator. It takes a Twig template like
and appends it to the output of the Templated metadata parser, like this:
How should this be tested?
This PR has a PHPUnit test but should also get a smoke test.
To run PHPUnit tests, in the MIK directory, run
phpunit
. You should getTests: 57, Assertions: 88, Skipped: 1.
To perform a smoketest:
composer dump-autoload
./mik -c issue-451.ini
Look at the XML files generated by MIK. They all should have a UUID element at the bottom.
issue-451.zip
Additional Notes
Yes, a wiki entry for this manipulator is at https://github.com/MarcusBarnes/mik/wiki/Metadata-manipulator:-AddUuidToTemplated.
A note about this manipulator should also be added to https://github.com/MarcusBarnes/mik/wiki/Cookbook:-Templated-Metadata-Parser.
Interested parties
@MarcusBarnes @bondjimbond