Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sanity_check.py #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update sanity_check.py #325

wants to merge 1 commit into from

Conversation

Marcello-Sega
Copy link
Owner

fixes a double call to guess radii, which creates trouble

@codecov
Copy link

codecov bot commented Sep 9, 2019 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (82b655e) to head (b90f41b).
Report is 42 commits behind head on master.

❗ Current head b90f41b differs from pull request most recent head 49c6764. Consider uploading reports for the commit 49c6764 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325       /-   ##
==========================================
  Coverage   85.05%   85.14%    0.08%     
==========================================
  Files          38       38              
  Lines        3005     2996       -9     
==========================================
- Hits         2556     2551       -5     
  Misses        449      445       -4
Files Coverage Δ
pytim/sanity_check.py 76.83% <ø> ( 1.28%) ⬆️

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0baf046...49c6764. Read the comment docs.

@Marcello-Sega
Copy link
Owner Author

@balazsfabian, this was left pending, do you remember why it was not merged?
I have some vague memory of you mentioning that it was not a good idea to remove that double call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Marcello-Sega