Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Introduce on click event on task #46

Merged
merged 1 commit into from
May 22, 2022
Merged

✨ Introduce on click event on task #46

merged 1 commit into from
May 22, 2022

Conversation

Lefevcal
Copy link

Hello,
I have introduced a feature to listen on click event
I hope it fits in your project
Thanks

@Lefevcal Lefevcal mentioned this pull request Feb 22, 2022
Closed
@MaTeMaTuK
Copy link
Owner

Hi @Lefevcal,
I really appreciate for you commit.
However, what is the difference between onClick and onSelect ?

@MaTeMaTuK MaTeMaTuK self-assigned this Feb 23, 2022
@Lefevcal
Copy link
Author

Hi @MaTeMaTuK
With the onSelect the function is not triggered if the element is already selected
I need the simple click to trigger a function which hide children tasks of a project task
And if the element is already selected and his children are hide, i need to select an other element to re click on the task to discover it children

@can-vaerks
Copy link

Please accept this, as we also need this for our project, and would like it to be implemented here instead of forking and implementing it ourselves :)

@MaTeMaTuK
Copy link
Owner

Ok. I will do this on this weekend with other changes.

@MaTeMaTuK MaTeMaTuK merged commit 84298ec into MaTeMaTuK:dev May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MaTeMaTuK MaTeMaTuK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lefevcal @MaTeMaTuK @can-vaerks