Hotfix: Downgrade Rack to 2.2.9 #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterfarrell9
changed the title
|
related: rack/rack#2128 and: rails/rails#49601 |
Open
|
To reproduce: upgrade to Rack 3, then go to the profile page. There should be an error thrown due to nested forms and how parameters are passed as arrays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some change in policy regarding how rack parses requests from version 3 on, some of our nested forms are parsed in way that produces an incorrect parameters hash in the controller. In this hotfix we downgrade to Rack 2.2.9. We have to go through each form, update them and migrate to Rack 3 at a later time.