Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send button without reply_to message #1351

Closed
akeinhell opened this issue Dec 20, 2019 · 1 comment
Closed

Send button without reply_to message #1351

akeinhell opened this issue Dec 20, 2019 · 1 comment
Labels
enhancement Nice to have things that are not a bug

Comments

@akeinhell
Copy link

akeinhell commented Dec 20, 2019 •
edited
Loading

methond click on the button, constantly making the reply to the message.

ex.:

async with self.bot.client.conversation(runner.chat) as conv:
    await conv.send_message('/get_keyboard')
    msg_with_button = await conv.get_response()
    await msg_with_button.click(text='text_of_the_button')

expected behavior:

  • client send only passed text
# example 
client.send_message(button.text)

current behavior:

is there an option to customize the use of the method?
@akeinhell akeinhell added the enhancement Nice to have things that are not a bug label Dec 20, 2019
Lonami added a commit that referenced this issue Dec 27, 2019
@Lonami
Don't reply to message on text button click (#1351)
bea4225 
Official clients don't do it, so we probably shouldn't either.
@Lonami
Copy link
Member

Lonami commented Dec 27, 2019

Official clients don't seem to ever reply to a message when pressing a button, so I guess we shouldn't either. The user can always client.send_message(chat, message.buttons[0][0].text) with a explicit reply if they wish to do so anyway.

@Lonami Lonami closed this as completed Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Nice to have things that are not a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akeinhell @Lonami