Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSOE-464: Surfacing configuration for xUnit maxParallelThreads in build workflow #309

Merged
merged 5 commits into from
Dec 8, 2022

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Dec 5, 2022

@github-actions github-actions bot changed the title Surfacing configuration for xUnit maxParallelThreads in build workflow OSOE-464: Surfacing configuration for xUnit maxParallelThreads in build workflow Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

This pull request has merge conflicts. Please resolve those before requesting a review.

…ax-parallel-threads

# Conflicts:
#	tools/Lombiq.GitHub.Actions
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

This pull request has merge conflicts. Please resolve those before requesting a review.

…ax-parallel-threads

# Conflicts:
#	tools/Lombiq.GitHub.Actions
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (57)
AFAFAF
autoinit
Bdata
Bubl
Builtins
cheatsheet
CHROMEWEBDRIVER
could've
cwj
datatables
dblclick
Dci
dest
dirname
downcase
emailtestsend
endgroup
eventname
extname
gpu
HHmmss
IAutoroute
ICalendar
IField
IManifest
ISupport
ITarget
IUI
IXL
izontal
JMES
jsnext
Kenobi
lastgremlinsclick
LCID
length'l
lombiqdt
lombiqtechnologies
lombiquitestingtoolbox
lstat
mediathemetest
mouseup
Myyyy
NNNN
permalink
registrationworkflow
search'f
SEH
shm
Singleline
testhttpevent
testworkflow
Tful
trumbowyg
Wqhd
XPATH
xunit
Previously acknowledged words that are now absent abcdef chromedriver dba editorconfig enableextensions eur favicon https itemprop json labelledby lockfile markdownlint mscorlib myapp NPM pnpm pragma publishsettings Rekt RSPEC sdk setlocal sourcemaps sql uri wpf wwwroot yaml yml
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Lombiq/Open-Source-Orchard-Core-Extensions.git repository
on the dev branch (ℹ️ how do I use this?):

update_files() {
mkdir -p '.github/actions/spelling/'
cp -i -R $(
cd $(mktemp -d)
git clone --depth 1 --no-tags https://github.com/Lombiq/GitHub-Actions --branch dev . > /dev/null 2> /dev/null
cd '.github/actions/spelling/'; pwd
)/* '.github/actions/spelling/'
git add '.github/actions/spelling/'
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
}

comment_json=$(mktemp)
curl -L -s -S \
-H "Content-Type: application/json" \
"https://api.github.com/repos/Lombiq/Open-Source-Orchard-Core-Extensions/issues/comments/1343254665" > "$comment_json"
comment_body=$(mktemp)
jq -r ".body // empty" "$comment_json" | tr -d "\\r" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")

patch_add=$(perl -e '$/=undef; $_=<>; if (m{Unrecognized words[^<]*</summary>\n*```\n*([^<]*)```\n*</details>$}m) { print "$1" } elsif (m{Unrecognized words[^<]*\n\n((?:\w.*\n) )\n}m) { print "$1" };' < "$comment_body")

update_files
rm $comment_body
git add -u
Available 📚 dictionaries could cover words not in the 📘 dictionary

This includes both expected items (168) from .github/actions/spelling/expect.txt and unrecognized words (57)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 31
cspell:software-terms/src/software-terms.txt 1237 27
cspell:node/node.txt 1768 19
cspell:python/src/python/python-lib.txt 3873 11
cspell:php/php.txt 2597 10

Consider adding them using (in .github/workflows/build-and-test.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:software-terms/src/software-terms.txt
          cspell:node/node.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
Warnings (1)

See the 📂 files view or the 📜action log for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 1

See ℹ️ Event descriptions for more information.

@sarahelsaig
Copy link
Member

I merely put the GHA branch selectors back to dev and now the spell checking broke. Any idea what's going on here?

@Piedone
Copy link
Member Author

Piedone commented Dec 8, 2022

Lombiq/GitHub-Actions#111 causes this, which Lombiq/GitHub-Actions#139 reverted. Thus re-running everything should fix it, what I just started.

@sarahelsaig
Copy link
Member

Cool, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants