Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant imu status check #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheMaster3558
Copy link
Contributor

@TheMaster3558 TheMaster3558 commented May 11, 2024

Summary

Removes the sensors.imu->get_status() != 0xFF from the loop that blocks until imu calibration is done.

Motivation

PROS has that condition to their is_calibrating() method so there is no need for it to be there anymore.

Test Plan

Idk if testing is needed for this, but I don't have access to a bot rn if it is

Additional Notes

It's interesting to note that the imu.reset() method with the blocking parameter set to true does not include this condition for some reason so it can't be used in place of the current blocking while loop.

Download the template for this pull request:

Note

This is auto generated from Add Template to Pull Request

curl -o [email protected] b92e0d.zip https://nightly.link/LemLib/LemLib/actions/artifacts/1493869145.zip;
pros c fetch [email protected] b92e0d.zip;
pros c apply [email protected] b92e0d;
rm [email protected] b92e0d.zip;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant