Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable rate limits and useful limit headers #2524

Merged

Conversation

jeppekroghitk
Copy link
Contributor

@jeppekroghitk jeppekroghitk commented May 28, 2024

Link to ticket

#1554

Description

Predefines the different rate limits in sample.env.
Implements the user configurable limits from .env and adds header to response with useful information for retrying.

Screenshot of the result

N/A

Checklist

  • My code passes all test cases.
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass the requirements on the checklist, you should add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer, please add them here.

@jeppekroghitk jeppekroghitk requested a review from a team as a code owner May 28, 2024 12:16
@jeppekroghitk jeppekroghitk requested review from marcelfolaron and removed request for a team May 28, 2024 12:16
@jeppekroghitk jeppekroghitk force-pushed the feature/configurable-rate-limiting branch from b7b37b4 to 89258e2 Compare May 28, 2024 12:29
Copy link
Contributor

@marcelfolaron marcelfolaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marcelfolaron marcelfolaron merged commit 8e64c9e into Leantime:master May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants