Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timesheet fixes #2361

Merged
merged 9 commits into from
Mar 1, 2024
Merged

Timesheet fixes #2361

merged 9 commits into from
Mar 1, 2024

Conversation

cableman
Copy link
Contributor

@cableman cableman commented Feb 29, 2024 •
edited
Loading

Link to ticket

#2322

Description

Look into timezone handling and the conversion of dates.

  • Switched to using carbon (https://carbon.nesbot.com) for date handling in timesheets
  • Ensure date are in UTC in all PHP code and first converted on display in UI to local timezone and format.
  • Added helper to format() to help during transition to carbon (as this is only change in timesheets for now)

Screenshot of the result

N/A

Checklist

  • My code passes all test cases.
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass the requirements on the checklist, you should add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

Builds on top of PR #2354 (which have been merged by now)

@cableman cableman force-pushed the feature/timesheet-carbon branch 2 times, most recently from 09a472c to d759eb0 Compare February 29, 2024 20:07
@cableman cableman marked this pull request as ready for review March 1, 2024 09:31
@cableman cableman requested a review from a team as a code owner March 1, 2024 09:31
@cableman cableman requested review from marcelfolaron and removed request for a team March 1, 2024 09:31
@cableman cableman changed the title WIP: Timesheet fixes Timesheet fixes Mar 1, 2024
@marcelfolaron
Copy link
Contributor

Thank you. Appreciate all the work that went into this.
We'll need to make sure to update the format() function and also all the other places using the datetimehelper.
I think we can refactor the date() and time() methods to do that. We won't need the 'long' format as there is no need for it on the frontend (it's either a date field or a time field, never both).

@marcelfolaron marcelfolaron merged commit 9ec0986 into Leantime:master Mar 1, 2024
4 checks passed
@marcelfolaron marcelfolaron mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelfolaron marcelfolaron Awaiting requested review from marcelfolaron marcelfolaron is a code owner automatically assigned from Leantime/developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cableman @marcelfolaron