Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Horizontal scrolling and overlap on TOC #185

Open
thany opened this issue Apr 29, 2016 · 3 comments
Open

[Docs] Horizontal scrolling and overlap on TOC #185

thany opened this issue Apr 29, 2016 · 3 comments

Comments

@thany
Copy link

thany commented Apr 29, 2016 •
edited
Loading

The navigation in the documentation is currently showing a horizontal scrollbar and isn't full-height.

I'm not sure if it's supposed to be full-height, but I think the horizontal scrollbar should be an easy fix by just making it slightly wider ;)

Here's a screenshot to show what I mean:
capture
(that's Firefox 45 on Windows 10)

And perhaps the beautiful red text "Contents" put on top of the red github-ribbon wasn't such a great idea, but then again, I think we all know what it says anyway :)

/edit
And now it's Firefox 46 :)
And that didn't fix it, as I kind of expected.
@LeaVerou LeaVerou changed the title Documentation navigation [Docs] Horizontal scrolling and overlap on TOC Apr 29, 2016
@LeaVerou
Copy link
Owner

Thanks! Could you type console.log(innerWidth, innerHeight) in the console and tell me what the values are when this happens?

@thany
Copy link
Author

thany commented Apr 29, 2016

Sure, here you go:

1731 1006

It seems fine when fully maximized on my WUXGA monitor, but not when almost maximized. I didn't notice that before.

@praveenpuglia
Copy link
Contributor

Looking at this issue and #188, I think it's safer to move the banner to the top right corner instead of keeping it on top left and worrying about it colliding with the sidebar for docs. That place seems safe to me. Only the Star button has to move slightly on the left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thany @LeaVerou @praveenpuglia