Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib now required in all system definitions? #453

Open
3 of 4 tasks
pearce8 opened this issue Nov 26, 2024 · 2 comments
Open
3 of 4 tasks

zlib now required in all system definitions? #453

pearce8 opened this issue Nov 26, 2024 · 2 comments
Assignees

Comments

@pearce8
Copy link
Collaborator

pearce8 commented Nov 26, 2024

I believe zlib was added to https://github.com/LLNL/benchpark/tree/develop/systems/genericx86/externals/base/00-packages.yaml to make Laghos work. We need to remove it from the system definitions.

  • sierra
  • tioga
  • genericx86
  • cts. Looks like the issue is building zlib-ng with gcc on sapphire rapids? @scheibelp
@rfhaque
Copy link
Collaborator

rfhaque commented Nov 26, 2024

I believe zlib was added to https://github.com/LLNL/benchpark/tree/develop/systems/genericx86/externals/base/00-packages.yaml to make Laghos work.

* [ ]  What was the reason?  Is this because we need the handle?

This was to avoid spack from defaulting to building zlib-ng, which does not work for non-intel compilers

* [ ]  Is the correct solution to put it in externals for each system?

Possibly. But that will assume every system has to have zlib installed

* [ ]  If yes, does every system definition have to have it? 
* [ ]  If yes, is there a better place to put it?

The Spack team may be able to clarify this better

@pearce8
Copy link
Collaborator Author

pearce8 commented Nov 26, 2024

After discussion 11/26, we should remove zlib from packages on all systems except for lassen. @rfhaque.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants