Revert "Refactor IPC handling in both client and daemon" #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest, neither did I. Maybe branch this into separate branch, because I don't think that on the whole the changes are incorrect, just some random thing either in The tests ran successfully and #331 worked, so this should do it. Sorry for the mess, I didn't realize that people can automatically use |
Eh, I broke the main branch many times before. We just have way more users now. Don't worry about it and enjoy your vacation. |
|
We can simply pull the diff from #331 later and fix whatever was wrong with it. |
|
Sure. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #333.
@rkuklik, I've never done this before, is this what you meant (I just clicked the "revert" button in the PR)?