Add ReadableWritableStorageTraits
automatically for all implementations
#59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54
As suggested, I added
ReadableWritableStorageTraits
to the defaultstorage_sync
implementation so that anything implementingReadableStorageTraits
andWritableStorageTraits
will have this trait as well. I also added a simple test for an async storage adapter to check that it is readable and writable.One potential issue with this approach is that it removes some of the custom commented mutex handling code in the various implementations. I'm not sure the use for that commented code. Do you think that will be a problem?
I'm happy to take a different approach here if necessary.