-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(robustness): add liveness check and readiness check #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
# Conflicts: # pkg/core/health/check.go # pkg/core/health/check_status_handler.go # pkg/core/health/check_test.go # pkg/core/health/storage_check.go
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
JasonHe-WQ
requested review from
elliotxx,
panshuai111,
adohe,
ffforest and
ruquanzhao
as code owners
July 15, 2024 14:23
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
elliotxx
reviewed
Jul 17, 2024
Signed-off-by: wenqing.he <[email protected]>
elliotxx
reviewed
Jul 20, 2024
elliotxx
reviewed
Jul 26, 2024
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
elliotxx
reviewed
Jul 29, 2024
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
Signed-off-by: wenqing.he <[email protected]>
elliotxx
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
For better robustness
Which issue(s) this PR fixes:
Issue #462
The connectivity of etcd and APIServer seems to be a build-in feature