From 4e0b4a4506c1bb2c284363f9bf04ad75ff453ea0 Mon Sep 17 00:00:00 2001
From: Dmitry Baev <baev.dm@gmail.com>
Date: Mon, 20 May 2019 22:26:31 +0300
Subject: [PATCH] add support for recursive meta annotations (via #359)

---
 .../allure/cucumber4jvm/LabelBuilder.java     |   2 +-
 .../io/qameta/allure/test/AllureFeatures.java |  52 ++-
 .../src/main/java/io/qameta/allure/Issue.java |   3 +
 .../src/main/java/io/qameta/allure/Link.java  |   1 +
 .../java/io/qameta/allure/LinkAnnotation.java |  14 +-
 .../io/qameta/allure/LinkAnnotations.java     |  36 ++
 .../main/java/io/qameta/allure/TmsLink.java   |   3 +
 .../qameta/allure/util/AnnotationUtils.java   | 148 ++++----
 .../io/qameta/allure/util/ResultsUtils.java   |   2 +-
 .../allure/util/AnnotationUtilsTest.java      | 356 ++++++++++++------
 10 files changed, 380 insertions(+), 237 deletions(-)
 create mode 100644 allure-java-commons/src/main/java/io/qameta/allure/LinkAnnotations.java

diff --git a/allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/LabelBuilder.java b/allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/LabelBuilder.java
index 609fecdf1..465f4c1e3 100644
--- a/allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/LabelBuilder.java
+++ b/allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/LabelBuilder.java
@@ -50,7 +50,7 @@
 /**
  * Scenario labels and links builder.
  */
-@SuppressWarnings({"CyclomaticComplexity", "PMD.CyclomaticComplexity", "PMD.NcssCount"})
+@SuppressWarnings({"CyclomaticComplexity", "PMD.CyclomaticComplexity", "PMD.NcssCount", "MultipleStringLiterals"})
 class LabelBuilder {
     private static final Logger LOGGER = LoggerFactory.getLogger(LabelBuilder.class);
     private static final String COMPOSITE_TAG_DELIMITER = "=";
diff --git a/allure-java-commons-test/src/main/java/io/qameta/allure/test/AllureFeatures.java b/allure-java-commons-test/src/main/java/io/qameta/allure/test/AllureFeatures.java
index f50e2672f..53a040a09 100644
--- a/allure-java-commons-test/src/main/java/io/qameta/allure/test/AllureFeatures.java
+++ b/allure-java-commons-test/src/main/java/io/qameta/allure/test/AllureFeatures.java
@@ -15,7 +15,7 @@
  */
 package io.qameta.allure.test;
 
-import io.qameta.allure.LabelAnnotation;
+import io.qameta.allure.Feature;
 
 import java.lang.annotation.Documented;
 import java.lang.annotation.ElementType;
@@ -24,8 +24,6 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
-import static io.qameta.allure.util.ResultsUtils.FEATURE_LABEL_NAME;
-
 /**
  * @author charlie (Dmitry Baev).
  */
@@ -37,7 +35,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Basic framework support")
+    @Feature("Basic framework support")
     @interface Base {
     }
 
@@ -45,7 +43,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Parallel test execution support")
+    @Feature("Parallel test execution support")
     @interface Parallel {
     }
 
@@ -53,7 +51,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Full name")
+    @Feature("Full name")
     @interface FullName {
     }
 
@@ -61,7 +59,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Display name")
+    @Feature("Display name")
     @interface DisplayName {
     }
 
@@ -69,7 +67,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Descriptions")
+    @Feature("Descriptions")
     @interface Descriptions {
     }
 
@@ -77,7 +75,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Timings")
+    @Feature("Timings")
     @interface Timings {
     }
 
@@ -85,7 +83,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Steps")
+    @Feature("Steps")
     @interface Steps {
     }
 
@@ -93,7 +91,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Attachments")
+    @Feature("Attachments")
     @interface Attachments {
     }
 
@@ -101,7 +99,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Parameters")
+    @Feature("Parameters")
     @interface Parameters {
     }
 
@@ -109,7 +107,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Fixtures")
+    @Feature("Fixtures")
     @interface Fixtures {
     }
 
@@ -117,7 +115,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Links")
+    @Feature("Links")
     @interface Links {
     }
 
@@ -125,7 +123,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Marker annotations")
+    @Feature("Marker annotations")
     @interface MarkerAnnotations {
     }
 
@@ -133,7 +131,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Failed tests")
+    @Feature("Failed tests")
     @interface FailedTests {
     }
 
@@ -141,7 +139,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Broken tests")
+    @Feature("Broken tests")
     @interface BrokenTests {
     }
 
@@ -149,7 +147,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Passed tests")
+    @Feature("Passed tests")
     @interface PassedTests {
     }
 
@@ -157,7 +155,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Skipped tests")
+    @Feature("Skipped tests")
     @interface SkippedTests {
     }
 
@@ -165,7 +163,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Ignored tests")
+    @Feature("Ignored tests")
     @interface IgnoredTests {
     }
 
@@ -173,7 +171,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Not implemented tests")
+    @Feature("Not implemented tests")
     @interface NotImplementedTests {
     }
 
@@ -181,7 +179,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "History")
+    @Feature("History")
     @interface History {
     }
 
@@ -189,7 +187,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Retries")
+    @Feature("Retries")
     @interface Retries {
     }
 
@@ -197,7 +195,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Stages")
+    @Feature("Stages")
     @interface Stages {
     }
 
@@ -205,7 +203,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Trees")
+    @Feature("Trees")
     @interface Trees {
     }
 
@@ -213,7 +211,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Timeline")
+    @Feature("Timeline")
     @interface Timeline {
     }
 
@@ -221,7 +219,7 @@
     @Inherited
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = FEATURE_LABEL_NAME, value = "Timeline")
+    @Feature("Timeline")
     @interface Severity {
     }
 }
diff --git a/allure-java-commons/src/main/java/io/qameta/allure/Issue.java b/allure-java-commons/src/main/java/io/qameta/allure/Issue.java
index 675366ad7..f795897c7 100644
--- a/allure-java-commons/src/main/java/io/qameta/allure/Issue.java
+++ b/allure-java-commons/src/main/java/io/qameta/allure/Issue.java
@@ -23,6 +23,8 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
+import static io.qameta.allure.util.ResultsUtils.ISSUE_LINK_TYPE;
+
 /**
  * Used to link tests with issues.
  */
@@ -30,6 +32,7 @@
 @Inherited
 @Retention(RetentionPolicy.RUNTIME)
 @Target({ElementType.METHOD, ElementType.TYPE})
+@LinkAnnotation(type = ISSUE_LINK_TYPE)
 @Repeatable(Issues.class)
 public @interface Issue {
 
diff --git a/allure-java-commons/src/main/java/io/qameta/allure/Link.java b/allure-java-commons/src/main/java/io/qameta/allure/Link.java
index 666da86a4..b0b4dacb6 100644
--- a/allure-java-commons/src/main/java/io/qameta/allure/Link.java
+++ b/allure-java-commons/src/main/java/io/qameta/allure/Link.java
@@ -38,6 +38,7 @@
 @Inherited
 @Retention(RetentionPolicy.RUNTIME)
 @Target({ElementType.METHOD, ElementType.TYPE})
+@LinkAnnotation
 @Repeatable(Links.class)
 public @interface Link {
 
diff --git a/allure-java-commons/src/main/java/io/qameta/allure/LinkAnnotation.java b/allure-java-commons/src/main/java/io/qameta/allure/LinkAnnotation.java
index 6b5ee1220..e646de636 100644
--- a/allure-java-commons/src/main/java/io/qameta/allure/LinkAnnotation.java
+++ b/allure-java-commons/src/main/java/io/qameta/allure/LinkAnnotation.java
@@ -18,6 +18,7 @@
 import java.lang.annotation.Documented;
 import java.lang.annotation.ElementType;
 import java.lang.annotation.Inherited;
+import java.lang.annotation.Repeatable;
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
@@ -36,15 +37,18 @@
 @Inherited
 @Retention(RetentionPolicy.RUNTIME)
 @Target({ElementType.ANNOTATION_TYPE})
+@Repeatable(LinkAnnotations.class)
 public @interface LinkAnnotation {
 
+    String DEFAULT_VALUE = "$$$$$$$$__value__$$$$$$$$";
+
     /**
      * The value of link. In not specified will take value from <code>value()</code>
      * method of target annotation.
      *
      * @return the value of the link to add.
      */
-    String value() default "";
+    String value() default DEFAULT_VALUE;
 
     /**
      * This type is used for create an icon for link. Also there is few reserved types such as issue and tms.
@@ -52,4 +56,12 @@
      * @return the link type.
      */
     String type() default CUSTOM_LINK_TYPE;
+
+    /**
+     * Url for link. By default will search for system property `allure.link.{type}.pattern`, and use it
+     * to generate url.
+     *
+     * @return the link url.
+     */
+    String url() default "";
 }
diff --git a/allure-java-commons/src/main/java/io/qameta/allure/LinkAnnotations.java b/allure-java-commons/src/main/java/io/qameta/allure/LinkAnnotations.java
new file mode 100644
index 000000000..50428d1c8
--- /dev/null
+++ b/allure-java-commons/src/main/java/io/qameta/allure/LinkAnnotations.java
@@ -0,0 +1,36 @@
+/*
+ *  Copyright 2019 Qameta Software OÜ
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+package io.qameta.allure;
+
+import java.lang.annotation.Documented;
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Inherited;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * Wrapper annotation for {@link LinkAnnotation}.
+ */
+@Documented
+@Inherited
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ElementType.ANNOTATION_TYPE})
+public @interface LinkAnnotations {
+
+    LinkAnnotation[] value();
+
+}
diff --git a/allure-java-commons/src/main/java/io/qameta/allure/TmsLink.java b/allure-java-commons/src/main/java/io/qameta/allure/TmsLink.java
index d80d7139f..d5e839017 100644
--- a/allure-java-commons/src/main/java/io/qameta/allure/TmsLink.java
+++ b/allure-java-commons/src/main/java/io/qameta/allure/TmsLink.java
@@ -23,6 +23,8 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
+import static io.qameta.allure.util.ResultsUtils.TMS_LINK_TYPE;
+
 /**
  * Used to link tests with test cases in external test management system.
  */
@@ -30,6 +32,7 @@
 @Inherited
 @Retention(RetentionPolicy.RUNTIME)
 @Target({ElementType.METHOD, ElementType.TYPE})
+@LinkAnnotation(type = TMS_LINK_TYPE)
 @Repeatable(TmsLinks.class)
 public @interface TmsLink {
 
diff --git a/allure-java-commons/src/main/java/io/qameta/allure/util/AnnotationUtils.java b/allure-java-commons/src/main/java/io/qameta/allure/util/AnnotationUtils.java
index c547d44ca..906c505a5 100644
--- a/allure-java-commons/src/main/java/io/qameta/allure/util/AnnotationUtils.java
+++ b/allure-java-commons/src/main/java/io/qameta/allure/util/AnnotationUtils.java
@@ -28,15 +28,15 @@
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.util.Collection;
-import java.util.Collections;
-import java.util.List;
-import java.util.ArrayList;
+import java.util.HashSet;
 import java.util.Objects;
 import java.util.Set;
-import java.util.function.Function;
+import java.util.function.BiFunction;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
+import static io.qameta.allure.util.ResultsUtils.createLabel;
+import static io.qameta.allure.util.ResultsUtils.createLink;
 import static java.util.Arrays.asList;
 
 /**
@@ -56,18 +56,13 @@ private AnnotationUtils() {
     }
 
     /**
-     * Returns links created from Allure annotations specified on annotated element.
+     * Returns links created from Allure meta annotations specified on annotated element.
      *
      * @param annotatedElement the element to search annotations on.
      * @return discovered links.
      */
-    public static List<Link> getLinks(final AnnotatedElement annotatedElement) {
-        final List<Link> result = new ArrayList<>();
-        result.addAll(extractLinks(annotatedElement, io.qameta.allure.Link.class, ResultsUtils::createLink));
-        result.addAll(extractLinks(annotatedElement, io.qameta.allure.Issue.class, ResultsUtils::createLink));
-        result.addAll(extractLinks(annotatedElement, io.qameta.allure.TmsLink.class, ResultsUtils::createLink));
-        result.addAll(extractCustomLinks(asList(annotatedElement.getDeclaredAnnotations())));
-        return result;
+    public static Set<Link> getLinks(final AnnotatedElement annotatedElement) {
+        return getLinks(annotatedElement.getDeclaredAnnotations());
     }
 
     /**
@@ -76,7 +71,7 @@ public static List<Link> getLinks(final AnnotatedElement annotatedElement) {
      * @param annotations annotations to analyse.
      * @return discovered links.
      */
-    public static List<Link> getLinks(final Annotation... annotations) {
+    public static Set<Link> getLinks(final Annotation... annotations) {
         return getLinks(asList(annotations));
     }
 
@@ -86,17 +81,13 @@ public static List<Link> getLinks(final Annotation... annotations) {
      * @param annotations annotations to analyse.
      * @return discovered links.
      */
-    public static List<Link> getLinks(final Collection<Annotation> annotations) {
-        final List<Link> result = new ArrayList<>();
-        result.addAll(extractLinks(annotations, io.qameta.allure.Link.class, ResultsUtils::createLink));
-        result.addAll(extractLinks(annotations, io.qameta.allure.Issue.class, ResultsUtils::createLink));
-        result.addAll(extractLinks(annotations, io.qameta.allure.TmsLink.class, ResultsUtils::createLink));
-        result.addAll(extractCustomLinks(annotations));
-        return result;
+    public static Set<Link> getLinks(final Collection<Annotation> annotations) {
+        return extractMetaAnnotations(LinkAnnotation.class, AnnotationUtils::extractLinks, annotations)
+                .collect(Collectors.toSet());
     }
 
     /**
-     * Returns labels created from Allure annotations specified on annotated element.
+     * Returns labels created from Allure meta annotations specified on annotated element.
      * Shortcut for {@link #getLinks(Annotation...)}
      *
      * @param annotatedElement the element to search annotations on.
@@ -123,84 +114,71 @@ public static Set<Label> getLabels(final Annotation... annotations) {
      * @return discovered labels.
      */
     public static Set<Label> getLabels(final Collection<Annotation> annotations) {
-        return annotations.stream()
-                .flatMap(AnnotationUtils::extractRepeatable)
-                .map(AnnotationUtils::getMarks)
-                .flatMap(Collection::stream)
-                .collect(Collectors.toSet());
-    }
-
-    private static <T extends Annotation> Set<Link> extractLinks(final AnnotatedElement element,
-                                                                 final Class<T> annotationType,
-                                                                 final Function<T, Link> mapper) {
-
-        return Stream.of(element.getAnnotationsByType(annotationType))
-                .map(mapper)
+        return extractMetaAnnotations(LabelAnnotation.class, AnnotationUtils::extractLabels, annotations)
                 .collect(Collectors.toSet());
     }
 
-    @SuppressWarnings("unchecked")
-    private static <T extends Annotation> Set<Link> extractLinks(final Collection<Annotation> annotations,
-                                                                 final Class<T> annotationType,
-                                                                 final Function<T, Link> mapper) {
-        return annotations.stream()
+    private static <T, U extends Annotation> Stream<T> extractMetaAnnotations(
+            final Class<U> annotationType,
+            final BiFunction<U, Annotation, Stream<T>> mapper,
+            final Collection<Annotation> candidates) {
+        final Set<Annotation> visited = new HashSet<>();
+        return candidates.stream()
                 .flatMap(AnnotationUtils::extractRepeatable)
-                .filter(annotation -> annotationType.isAssignableFrom(annotation.annotationType()))
-                .map(annotation -> (T) annotation)
-                .map(mapper)
-                .collect(Collectors.toSet());
+                .flatMap(candidate -> extractMetaAnnotations(annotationType, mapper, candidate, visited));
+    }
+
+    private static <T, U extends Annotation> Stream<T> extractMetaAnnotations(
+            final Class<U> annotationType,
+            final BiFunction<U, Annotation, Stream<T>> mapper,
+            final Annotation candidate,
+            final Set<Annotation> visited) {
+        if (!isInJavaLangAnnotationPackage(candidate.annotationType()) && visited.add(candidate)) {
+            final Stream<T> children = Stream.of(candidate.annotationType().getAnnotations())
+                    .flatMap(AnnotationUtils::extractRepeatable)
+                    .flatMap(annotation -> extractMetaAnnotations(
+                            annotationType, mapper, annotation, visited));
+            final Stream<T> current = Stream.of(candidate.annotationType().getAnnotationsByType(annotationType))
+                    .flatMap(marker -> mapper.apply(marker, candidate));
+            return Stream.concat(current, children);
+        }
+        return Stream.empty();
     }
 
-    private static Collection<? extends Link> extractCustomLinks(final Collection<Annotation> annotations) {
-        return annotations.stream()
-                .flatMap(AnnotationUtils::extractRepeatable)
-                .filter(annotation -> annotation.annotationType().isAnnotationPresent(LinkAnnotation.class))
-                .flatMap(annotation -> AnnotationUtils.toLink(annotation).stream())
-                .collect(Collectors.toSet());
+    private static Stream<Label> extractLabels(final LabelAnnotation m, final Annotation annotation) {
+        if (Objects.equals(m.value(), LabelAnnotation.DEFAULT_VALUE)) {
+            return callValueMethod(annotation)
+                    .map(value -> createLabel(m.name(), value));
+        }
+        return Stream.of(createLabel(m.name(), m.value()));
     }
 
-    private static Set<Link> toLink(final Annotation annotation) {
-        final LinkAnnotation linkAnnotation = annotation.annotationType().getAnnotation(LinkAnnotation.class);
+    private static Stream<Link> extractLinks(final LinkAnnotation m, final Annotation annotation) {
+        // this is required as Link annotation uses name attribute as value alias.
+        if (annotation instanceof io.qameta.allure.Link) {
+            return Stream.of(createLink((io.qameta.allure.Link) annotation));
+        }
 
+        if (Objects.equals(m.value(), LinkAnnotation.DEFAULT_VALUE)) {
+            return callValueMethod(annotation)
+                    .map(value -> createLink(value, null, m.url(), m.type()));
+        }
+        return Stream.of(createLink(m.value(), null, m.url(), m.type()));
+    }
+
+    private static Stream<String> callValueMethod(final Annotation annotation) {
         try {
             final Method method = annotation.annotationType().getMethod(VALUE_METHOD_NAME);
             final Object object = method.invoke(annotation);
-            return objectToStringStream(object)
-                    .map(value -> ResultsUtils.createLink("", value, "", linkAnnotation.type()))
-                    .collect(Collectors.toSet());
+            return objectToStringStream(object);
         } catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) {
             LOGGER.error(
-                    "Invalid annotation {}: marker annotations should contains value() method",
-                    annotation
+                    "Invalid annotation {}: marker annotations without value should contains value() method",
+                    annotation,
+                    e
             );
+            return Stream.empty();
         }
-        return Collections.emptySet();
-    }
-
-    private static Set<Label> getMarks(final Annotation annotation) {
-        return Stream.of(annotation.annotationType().getAnnotationsByType(LabelAnnotation.class))
-                .map(marker -> getLabel(annotation, marker))
-                .flatMap(Collection::stream)
-                .collect(Collectors.toSet());
-    }
-
-    private static Set<Label> getLabel(final Annotation annotation, final LabelAnnotation m) {
-        if (Objects.equals(m.value(), LabelAnnotation.DEFAULT_VALUE)) {
-            try {
-                final Method method = annotation.annotationType().getMethod(VALUE_METHOD_NAME);
-                final Object object = method.invoke(annotation);
-                return objectToStringStream(object)
-                        .map(value -> new Label().setName(m.name()).setValue(value))
-                        .collect(Collectors.toSet());
-            } catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) {
-                LOGGER.error(
-                        "Invalid annotation {}: marker annotations without value should contains value() method",
-                        annotation
-                );
-                return Collections.emptySet();
-            }
-        }
-        return Collections.singleton(new Label().setName(m.name()).setValue(m.value()));
     }
 
     @SuppressWarnings({
@@ -258,4 +236,8 @@ private static boolean isRepeatable(final Class<?> annotationType) {
         return annotationType.isAnnotationPresent(Repeatable.class);
     }
 
+    private static boolean isInJavaLangAnnotationPackage(final Class<? extends Annotation> annotationType) {
+        return annotationType != null && annotationType.getName().startsWith("java.lang.annotation");
+    }
+
 }
diff --git a/allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java b/allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java
index 5d7148abd..b3a4beb88 100644
--- a/allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java
+++ b/allure-java-commons/src/main/java/io/qameta/allure/util/ResultsUtils.java
@@ -179,7 +179,7 @@ public static Label createLanguageLabel(final String language) {
     }
 
     public static Label createLabel(final String name, final String value) {
-        return new Label().setName(LANGUAGE_LABEL_NAME).setValue(value);
+        return new Label().setName(name).setValue(value);
     }
 
     public static Label createLabel(final Owner owner) {
diff --git a/allure-java-commons/src/test/java/io/qameta/allure/util/AnnotationUtilsTest.java b/allure-java-commons/src/test/java/io/qameta/allure/util/AnnotationUtilsTest.java
index 973ce6da6..5c346ddd2 100644
--- a/allure-java-commons/src/test/java/io/qameta/allure/util/AnnotationUtilsTest.java
+++ b/allure-java-commons/src/test/java/io/qameta/allure/util/AnnotationUtilsTest.java
@@ -25,6 +25,7 @@
 import io.qameta.allure.Link;
 import io.qameta.allure.LinkAnnotation;
 import io.qameta.allure.Links;
+import io.qameta.allure.Owner;
 import io.qameta.allure.Story;
 import io.qameta.allure.TmsLink;
 import io.qameta.allure.TmsLinks;
@@ -53,40 +54,31 @@
  */
 class AnnotationUtilsTest {
 
-    @Test
-    void shouldExtractEpic() {
-        final Set<Label> labels = getLabels(WithBddAnnotations.class);
-        assertThat(labels)
-                .extracting(Label::getName, Label::getValue)
-                .contains(tuple(EPIC_LABEL_NAME, "e1"));
-    }
-
-    @Test
-    void shouldExtractLabelsFromGivenAnnotations() {
-        final Set<Label> labels = getLabels(WithBddAnnotations.class.getDeclaredAnnotations());
-        assertThat(labels)
-                .extracting(Label::getName, Label::getValue)
-                .contains(tuple(EPIC_LABEL_NAME, "e1"));
+    @Epic("e1")
+    @Feature("f1")
+    @Story("s1")
+    class WithBddAnnotations {
     }
 
     @Test
-    void shouldExtractFeature() {
+    void shouldExtractDefaultLabels() {
         final Set<Label> labels = getLabels(WithBddAnnotations.class);
         assertThat(labels)
                 .extracting(Label::getName, Label::getValue)
-                .contains(tuple(FEATURE_LABEL_NAME, "f1"));
+                .contains(
+                        tuple(EPIC_LABEL_NAME, "e1"),
+                        tuple(FEATURE_LABEL_NAME, "f1"),
+                        tuple(STORY_LABEL_NAME, "s1")
+                );
     }
 
-    @Test
-    void shouldExtractStory() {
-        final Set<Label> labels = getLabels(WithBddAnnotations.class);
-        assertThat(labels)
-                .extracting(Label::getName, Label::getValue)
-                .contains(tuple(STORY_LABEL_NAME, "s1"));
+    @Epic("e1")
+    @Epic("e2")
+    class RepeatableAnnotations {
     }
 
     @Test
-    void shouldExtractRepeatableEpic() {
+    void shouldExtractRepeatableLabels() {
         final Set<Label> labels = getLabels(RepeatableAnnotations.class);
         assertThat(labels)
                 .extracting(Label::getName, Label::getValue)
@@ -96,8 +88,15 @@ void shouldExtractRepeatableEpic() {
                 );
     }
 
+    @Epics({
+            @Epic("e1"),
+            @Epic("e2")
+    })
+    class DirectRepeatableAnnotations {
+    }
+
     @Test
-    void shouldExtractDirectRepeatableEpic() {
+    void shouldExtractDirectRepeatableLabels() {
         final Set<Label> labels = getLabels(DirectRepeatableAnnotations.class);
         assertThat(labels)
                 .extracting(Label::getName, Label::getValue)
@@ -107,6 +106,19 @@ void shouldExtractDirectRepeatableEpic() {
                 );
     }
 
+    @Retention(RetentionPolicy.RUNTIME)
+    @Target({ElementType.METHOD, ElementType.TYPE})
+    @LabelAnnotation(name = "custom")
+    @interface Custom {
+
+        String value();
+
+    }
+
+    @Custom("Some")
+    class CustomAnnotation {
+    }
+
     @Test
     void shouldExtractCustomAnnotations() {
         final Set<Label> labels = getLabels(CustomAnnotation.class);
@@ -117,6 +129,19 @@ void shouldExtractCustomAnnotations() {
                 );
     }
 
+    @Retention(RetentionPolicy.RUNTIME)
+    @Target({ElementType.METHOD, ElementType.TYPE})
+    @LabelAnnotation(name = "custom")
+    @interface CustomMultiValue {
+
+        String[] value();
+
+    }
+
+    @CustomMultiValue({"First", "Second"})
+    class CustomMultiValueAnnotation {
+    }
+
     @Test
     void shouldSupportMultiValueAnnotations() {
         final Set<Label> labels = getLabels(CustomMultiValueAnnotation.class);
@@ -128,6 +153,16 @@ void shouldSupportMultiValueAnnotations() {
                 );
     }
 
+    @Retention(RetentionPolicy.RUNTIME)
+    @Target({ElementType.METHOD, ElementType.TYPE})
+    @LabelAnnotation(name = "custom", value = "fixed")
+    @interface CustomFixed {
+    }
+
+    @CustomFixed
+    class CustomFixedAnnotation {
+    }
+
     @Test
     void shouldSupportCustomFixedAnnotations() {
         final Set<Label> labels = getLabels(CustomFixedAnnotation.class);
@@ -138,6 +173,19 @@ void shouldSupportCustomFixedAnnotations() {
                 );
     }
 
+    @Retention(RetentionPolicy.RUNTIME)
+    @Target({ElementType.METHOD, ElementType.TYPE})
+    @LabelAnnotation(name = "a", value = "a1")
+    @LabelAnnotation(name = "a", value = "a2")
+    @LabelAnnotation(name = "b", value = "b1")
+    @LabelAnnotation(name = "b", value = "b2")
+    @interface CustomMultiLabel {
+    }
+
+    @CustomMultiLabel
+    class CustomMultiLabelAnnotation {
+    }
+
     @Test
     void shouldSupportCustomMultiLabelAnnotations() {
         final Set<Label> labels = getLabels(CustomMultiLabelAnnotation.class);
@@ -151,6 +199,24 @@ void shouldSupportCustomMultiLabelAnnotations() {
                 );
     }
 
+    @Link(name = "LINK-1")
+    @Links({
+            @Link(name = "LINK-2", url = "https://example.org/link/2"),
+            @Link(url = "https://example.org/some-custom-link")
+    })
+    @TmsLink("TMS-1")
+    @TmsLinks({
+            @TmsLink("TMS-2"),
+            @TmsLink("TMS-3")
+    })
+    @Issue("ISSUE-1")
+    @Issues({
+            @Issue("ISSUE-2"),
+            @Issue("ISSUE-3")
+    })
+    class WithLinks {
+    }
+
     @ResourceLock(value = SYSTEM_PROPERTIES, mode = READ_WRITE)
     @SystemProperty(name = "allure.link.issue.pattern", value = "https://example.org/issue/{}")
     @SystemProperty(name = "allure.link.tms.pattern", value = "https://example.org/tms/{}")
@@ -158,7 +224,10 @@ void shouldSupportCustomMultiLabelAnnotations() {
     @Test
     void shouldExtractLinks() {
         assertThat(getLinks(WithLinks.class))
-                .extracting(io.qameta.allure.model.Link::getName, io.qameta.allure.model.Link::getType, io.qameta.allure.model.Link::getUrl)
+                .extracting(
+                        io.qameta.allure.model.Link::getName,
+                        io.qameta.allure.model.Link::getType,
+                        io.qameta.allure.model.Link::getUrl)
                 .contains(
                         tuple("LINK-1", "custom", "https://example.org/custom/LINK-1"),
                         tuple("LINK-2", "custom", "https://example.org/link/2"),
@@ -172,140 +241,179 @@ void shouldExtractLinks() {
                 );
     }
 
-    @ResourceLock(value = SYSTEM_PROPERTIES, mode = READ_WRITE)
-    @SystemProperty(name = "allure.link.issue.pattern", value = "https://example.org/issue/{}")
-    @SystemProperty(name = "allure.link.tms.pattern", value = "https://example.org/tms/{}")
-    @SystemProperty(name = "allure.link.custom.pattern", value = "https://example.org/custom/{}")
-    @Test
-    void shouldExtractLinksFromAnnotationList() {
-        assertThat(getLinks(WithLinks.class.getDeclaredAnnotations()))
-                .extracting(io.qameta.allure.model.Link::getName, io.qameta.allure.model.Link::getType, io.qameta.allure.model.Link::getUrl)
-                .contains(
-                        tuple("LINK-1", "custom", "https://example.org/custom/LINK-1"),
-                        tuple("LINK-2", "custom", "https://example.org/link/2"),
-                        tuple("", "custom", "https://example.org/some-custom-link"),
-                        tuple("ISSUE-1", "issue", "https://example.org/issue/ISSUE-1"),
-                        tuple("ISSUE-2", "issue", "https://example.org/issue/ISSUE-2"),
-                        tuple("ISSUE-3", "issue", "https://example.org/issue/ISSUE-3"),
-                        tuple("TMS-1", "tms", "https://example.org/tms/TMS-1"),
-                        tuple("TMS-2", "tms", "https://example.org/tms/TMS-2"),
-                        tuple("TMS-3", "tms", "https://example.org/tms/TMS-3")
-                );
+    @Retention(RetentionPolicy.RUNTIME)
+    @Target({ElementType.METHOD, ElementType.TYPE})
+    @LinkAnnotation
+    @interface CustomLink {
+        String value() default "";
+    }
+
+    @Retention(RetentionPolicy.RUNTIME)
+    @Target({ElementType.METHOD, ElementType.TYPE})
+    @LinkAnnotation(type = "issue")
+    @interface CustomIssue {
+        String value();
+    }
+
+    @CustomLink("LINK-2")
+    @Link("LINK-1")
+    @CustomIssue("ISSUE-1")
+    class WithCustomLink {
     }
 
     @ResourceLock(value = SYSTEM_PROPERTIES, mode = READ_WRITE)
     @SystemProperty(name = "allure.link.custom.pattern", value = "https://example.org/custom/{}")
-    @SystemProperty(name = "allure.link.tms.pattern", value = "https://tms.com/custom/{}")
+    @SystemProperty(name = "allure.link.issue.pattern", value = "https://example.org/issue/{}")
     @Test
     void shouldExtractCustomLinks() {
-        assertThat(getLinks(WithCustomLink.class.getDeclaredAnnotations()))
+        assertThat(getLinks(WithCustomLink.class))
                 .extracting(io.qameta.allure.model.Link::getUrl)
-                .containsOnly("https://example.org/custom/LINK-2",
+                .containsOnly(
+                        "https://example.org/custom/LINK-2",
                         "https://example.org/custom/LINK-1",
-                        "https://tms.com/custom/ISSUE-1");
-    }
-
-    @Epic("e1")
-    @Feature("f1")
-    @Story("s1")
-    class WithBddAnnotations {
-    }
-
-    @Epic("e1")
-    @Epic("e2")
-    class RepeatableAnnotations {
-    }
-
-    @Epics({
-            @Epic("e1"),
-            @Epic("e2")
-    })
-    class DirectRepeatableAnnotations {
+                        "https://example.org/issue/ISSUE-1"
+                );
     }
 
-    @Custom("Some")
-    class CustomAnnotation {
+    @Retention(RetentionPolicy.RUNTIME)
+    @Target({ElementType.METHOD, ElementType.TYPE})
+    @Feature("First")
+    @Issue("1")
+    @interface FirstFeature {
     }
 
-    @CustomMultiValue({"First", "Second"})
-    class CustomMultiValueAnnotation {
+    @Retention(RetentionPolicy.RUNTIME)
+    @Target({ElementType.METHOD, ElementType.TYPE})
+    @Feature("Second")
+    @Issue("2")
+    @interface SecondFeature {
     }
 
-    @CustomFixed
-    class CustomFixedAnnotation {
+    @Retention(RetentionPolicy.RUNTIME)
+    @Target({ElementType.METHOD, ElementType.TYPE})
+    @FirstFeature
+    @SecondFeature
+    @Story("Other")
+    @interface OtherStory {
     }
 
-    @CustomMultiLabel
-    class CustomMultiLabelAnnotation {
+    @OtherStory
+    class WithMultiFeature {
     }
 
-    @Link(name = "LINK-1")
-    @Links({
-            @Link(name = "LINK-2", url = "https://example.org/link/2"),
-            @Link(url = "https://example.org/some-custom-link")
-    })
-    @TmsLink("TMS-1")
-    @TmsLinks({
-            @TmsLink("TMS-2"),
-            @TmsLink("TMS-3")
-    })
-    @Issue("ISSUE-1")
-    @Issues({
-            @Issue("ISSUE-2"),
-            @Issue("ISSUE-3")
-    })
-    class WithLinks {
+    @Test
+    void shouldSupportMultiFeature() {
+        final Set<Label> labels = getLabels(WithMultiFeature.class);
+        assertThat(labels)
+                .extracting(Label::getName, Label::getValue)
+                .contains(
+                        tuple("feature", "First"),
+                        tuple("feature", "Second"),
+                        tuple("story", "Other")
+                );
     }
 
     @Retention(RetentionPolicy.RUNTIME)
     @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = "custom")
-    public @interface Custom {
-
+    @Recursive("second")
+    @LabelAnnotation(name = "recursive")
+    @interface Recursive {
         String value();
-
     }
 
-    @Retention(RetentionPolicy.RUNTIME)
-    @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = "custom")
-    public @interface CustomMultiValue {
-
-        String[] value();
+    @Recursive("first")
+    class WithRecurse {
+    }
 
+    @Test
+    void shouldExtractLabelsFromRecursiveAnnotations() {
+        final Set<Label> labels = getLabels(WithRecurse.class);
+        assertThat(labels)
+                .extracting(Label::getName, Label::getValue)
+                .contains(
+                        tuple("recursive", "first"),
+                        tuple("recursive", "second")
+                );
     }
 
     @Retention(RetentionPolicy.RUNTIME)
-    @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = "custom", value = "fixed")
-    public @interface CustomFixed {
+    @Target({})
+    @interface Features {
+
+        @Retention(RetentionPolicy.RUNTIME)
+        @Target({ElementType.TYPE})
+        @Feature("A")
+        @Owner("tester1")
+        @Link(url = "https://example.org/features/A")
+        @interface FeatureA {
+
+            @Retention(RetentionPolicy.RUNTIME)
+            @Target({ElementType.METHOD, ElementType.TYPE})
+            @FeatureA
+            @Story("s1")
+            @interface Story1 {
+            }
+        }
+
+        @Retention(RetentionPolicy.RUNTIME)
+        @Target({ElementType.TYPE})
+        @Feature("B")
+        @Owner("tester2")
+        @Link(url = "https://example.org/features/B")
+        @interface FeatureB {
+
+            @Retention(RetentionPolicy.RUNTIME)
+            @Target({ElementType.METHOD, ElementType.TYPE})
+            @FeatureB
+            @Story("s2")
+            @interface Story2 {
+            }
+        }
     }
 
-    @Retention(RetentionPolicy.RUNTIME)
-    @Target({ElementType.METHOD, ElementType.TYPE})
-    @LabelAnnotation(name = "a", value = "a1")
-    @LabelAnnotation(name = "a", value = "a2")
-    @LabelAnnotation(name = "b", value = "b1")
-    @LabelAnnotation(name = "b", value = "b2")
-    public @interface CustomMultiLabel {
+    @Features.FeatureA.Story1
+    class Test1 {
     }
 
-    @Retention(RetentionPolicy.RUNTIME)
-    @Target({ElementType.METHOD, ElementType.TYPE})
-    @LinkAnnotation
-    public @interface CustomLink {
-        String value() default "";
+    @Features.FeatureB.Story2
+    class Test2 {
     }
 
-    @Retention(RetentionPolicy.RUNTIME)
-    @Target({ElementType.METHOD, ElementType.TYPE})
-    @LinkAnnotation(type = "tms")
-    public @interface CustomIssue {
-        String value();
+    @Features.FeatureA.Story1
+    @Features.FeatureB.Story2
+    class Test3 {
     }
 
-    @CustomLink("LINK-2")
-    @Link("LINK-1")
-    @CustomIssue("ISSUE-1")
-    class WithCustomLink { }
+    @Test
+    void complexCase() {
+        final Set<Label> labels1 = getLabels(Test1.class);
+        assertThat(labels1)
+                .extracting(Label::getName, Label::getValue)
+                .containsExactlyInAnyOrder(
+                        tuple("feature", "A"),
+                        tuple("story", "s1"),
+                        tuple("owner", "tester1")
+                );
+
+        final Set<Label> labels2 = getLabels(Test2.class);
+        assertThat(labels2)
+                .extracting(Label::getName, Label::getValue)
+                .containsExactlyInAnyOrder(
+                        tuple("feature", "B"),
+                        tuple("story", "s2"),
+                        tuple("owner", "tester2")
+                );
+
+        final Set<Label> labels3 = getLabels(Test3.class);
+        assertThat(labels3)
+                .extracting(Label::getName, Label::getValue)
+                .containsExactlyInAnyOrder(
+                        tuple("feature", "A"),
+                        tuple("story", "s1"),
+                        tuple("owner", "tester1"),
+                        tuple("feature", "B"),
+                        tuple("story", "s2"),
+                        tuple("owner", "tester2")
+                );
+    }
 }