Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sample project] Added missing pluginApiPreviewAcknowledgement() override #3671

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

jisungbin
Copy link
Contributor

@jisungbin jisungbin commented Jul 5, 2024

Add the missing abstract function implementations to build the "hide-internal-api" sample project successfully.

However, I noticed that the entire sample project is disabled in the IDE (by not including it in settings.gradle).

If you decide not to maintain the sample project, you can close this PR.

Copy link
Contributor

@whyoleg whyoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For some reason, this specific sample is not configured to run on CI.
There is no need to include those samples in settings.gradle.kts because they use Dokka released to Maven Central and so need to be updated only during release.

@whyoleg whyoleg merged commit 02db40b into Kotlin:master Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants