Update Analysis API to 2.0.20-dev-6911 #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of changes: - KT-68462 - partially KT-68884 and others
whyoleg
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Overall, nice!
Still, there are two things I want to resolve:
- consistent naming: some declarations in AA changed their names, and so some of our functions are also changed, but others don't. I do have two suggestions here, it would be nice to consistently use one of them:
- we change everything to align with the new naming
- we change nothing until AA is stable enough and no renaming is expected
- using of sequences: AFAIU AA almost all the time returns sequences, and in our case we need to handle most of the declarations from those sequences. I believe we should convert them to lists as soon as possible to not stick in a situation that we recreate those sequences on every call. This was the issue which I fixed not so long ago which causes big performance degradation in K2 analysis.
...tlin/org/jetbrains/dokka/analysis/kotlin/symbols/services/SymbolFullClassHierarchyBuilder.kt
Outdated
Show resolved
Hide resolved
...tlin/org/jetbrains/dokka/analysis/kotlin/symbols/services/SymbolFullClassHierarchyBuilder.kt
Outdated
Show resolved
Hide resolved
...tlin/org/jetbrains/dokka/analysis/kotlin/symbols/services/SymbolFullClassHierarchyBuilder.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/org/jetbrains/dokka/analysis/kotlin/symbols/translators/AnnotationTranslator.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/org/jetbrains/dokka/analysis/kotlin/symbols/translators/AnnotationTranslator.kt
Outdated
Show resolved
Hide resolved
...ymbols/src/main/kotlin/org/jetbrains/dokka/analysis/kotlin/symbols/translators/DRIFactory.kt
Outdated
Show resolved
Hide resolved
...jetbrains/dokka/analysis/kotlin/symbols/translators/DefaultSymbolToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
...jetbrains/dokka/analysis/kotlin/symbols/translators/DefaultSymbolToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
...jetbrains/dokka/analysis/kotlin/symbols/translators/DefaultSymbolToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
...ls/src/main/kotlin/org/jetbrains/dokka/analysis/kotlin/symbols/translators/TypeTranslator.kt
Show resolved
Hide resolved
I am trying to do the former to avoid forgotten context. My approach is
I agree, it is a good point. Using sequences from AA should be moderated. |
vmishenev
force-pushed
the
vmishenev/Update-Analysis-API-to-2.0.20-dev-6911
branch
from
a5e1351
to
ef9bf7f
Compare
whyoleg
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes: