feat: reworked navbar component #3648
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berezinant
force-pushed
the
ktl-1543-design-tokens
branch
2 times, most recently
from
01d35c8
to
6df00b2
Compare
berezinant
force-pushed
the
ktl-1543-design-tokens
branch
from
6df00b2
to
ecbb971
Compare
berezinant
force-pushed
the
ktl-1545-layout
branch
3 times, most recently
from
b44a604
to
1d6ff84
Compare
berezinant
commented
Jul 8, 2024
| @@ -5,16 5,6 @@ | |||
| module.exports = () => ({ | |||
| plugins: [ | |||
| require('postcss-import'), | |||
| require('postcss-preset-env')({ | |||
There was a problem hiding this comment.
this only produced a waring about unknown postcss features options
berezinant
commented
Jul 8, 2024
| directory: '../../dokka-integration-tests/gradle/build/ui-showcase-result', | ||
| }, | ||
| devMiddleware: { | ||
| writeToDisk: (filePath) => { |
There was a problem hiding this comment.
this forces webpack to rewrite ui-kit's output on every dev server reload
berezinant
commented
Jul 8, 2024
| onDoneWatch: { | ||
| scripts: [ | ||
| 'echo "Done rebuild, coping files to dokka-integration-tests"', | ||
| 'cp -r ../plugin-base/src/main/resources/dokka/ui-kit ../../dokka-integration-tests/gradle/build/ui-showcase-result', |
There was a problem hiding this comment.
and this copies rewritten ui-kit's output to the ui-showcase directory so the changes are reflected immediately
berezinant
commented
Jul 8, 2024
| @@ -104,6 104,12 @@ public class StylesInstaller(private val dokkaContext: DokkaContext) : PageTrans | |||
|
|
|||
| public object AssetsInstaller : PageTransformer { | |||
| private val imagesPages = listOf( | |||
| // ui-kit assets | |||
| "ui-kit/assets/burger.svg", | |||
There was a problem hiding this comment.
For now there is no way to register all content from the directory so we have to register it file by file
berezinant
force-pushed
the
ktl-1545-layout
branch
2 times, most recently
from
b2d0642
to
606ac96
Compare
berezinant
force-pushed
the
ktl-1543-design-tokens
branch
from
ecbb971
to
130d57c
Compare
berezinant
force-pushed
the
ktl-1545-layout
branch
from
606ac96
to
ebc4093
Compare
berezinant
force-pushed
the
ktl-1543-design-tokens
branch
from
130d57c
to
8a0cc03
Compare
berezinant
force-pushed
the
ktl-1545-layout
branch
from
ebc4093
to
48adff5
Compare
berezinant
force-pushed
the
ktl-1545-layout
branch
from
48adff5
to
fef3436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.