Update Kotlin to 2.0.0-RC3 #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyoleg
commented
May 13, 2024
| import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension | ||
| import org.jetbrains.kotlin.gradle.dsl.KotlinSingleTargetExtension | ||
| import org.jetbrains.kotlin.gradle.plugin.KotlinSourceSet | ||
| import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinCommonCompilation | ||
|
|
||
| internal typealias KotlinCompilation = | ||
| org.jetbrains.kotlin.gradle.plugin.KotlinCompilation<KotlinCommonOptions> | ||
| internal typealias KotlinCompilation = org.jetbrains.kotlin.gradle.plugin.KotlinCompilation<*> |
There was a problem hiding this comment.
KotlinCommonOptions is deprecated
There was a problem hiding this comment.
I'm surprised that it worked :) I thought we would need to use the replacements here, which could lead to compatibility problems with the older versions of KGP
IgnatBeresnev
approved these changes
May 13, 2024
vmishenev
approved these changes
May 13, 2024
IgnatBeresnev
pushed a commit
that referenced
this pull request
May 13, 2024
(cherry picked from commit a4b4ba8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.