Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another take at removing the kotlin-stdlib dependency from the Gradle Plugin #2570

Merged

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Jul 14, 2022

Follow up from #2543
See also this kotlinlang slack discussion

Looks like the "com.gradle.plugin-publish" creates its own pom that doesn't find "configuration-level" excludes but requires "dependency-level" exclude. This PR mimics the behaviour from the Kotlin Gradle Plugin. It's hard to test end to end, especially since "com.gradle.plugin-publish" is closed source but I could verify that the file at dokka/runners/gradle-plugin/build/publish-generated-resources/pom.xml now contains excludes 🤞

@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Jul 15, 2022

Thank you yet again for helping with this! it's of enormous help :)

It is indeed difficult to test it. For maven repos we can publish it to the snapshot repository and test it through it, but there's nothing like gradlePluginSnapshotRepository(), right?

Anyhow I think it's worth giving it a shot. Let's wait for integration tests to pass, and I'll test it manually for maven repos, make sure it's working at least for maven central, and we'll merge it

@martinbonnin
Copy link
Contributor Author

For maven repos we can publish it to the snapshot repository and test it through it, but there's nothing like gradlePluginSnapshotRepository(), right?

Not that I'm aware of unfortunately :(. The portal allows you to delete a version shortly it has been uploaded so I guess one way to test, if you have access to the the portal credentials, is to upload manually and to end-to-end testing. Not ideal but I don't really see another way.

Let's wait for integration tests to pass, and I'll test it manually for maven repos, make sure it's working at least for maven central, and we'll merge it

Sounds good 👍 . It's the same code as the Kotlin plugin dokka/runners/gradle-plugin/build/publish-generated-resources/pom.xml did change so 🤞 it's all good this time.

Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks once again for the contribution!

@IgnatBeresnev IgnatBeresnev merged commit b6a8e58 into Kotlin:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants