Skip to content

Commit

Permalink
fix dokka-base-test-utils exposing runtime dependency on descriptors …
Browse files Browse the repository at this point in the history
…analysis (#3621)
  • Loading branch information
whyoleg committed May 30, 2024
1 parent 52ff374 commit 5a9e236
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 25 deletions.
4 changes: 4 additions & 0 deletions dokka-subprojects/plugin-all-modules-page/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 7,7 @@ import dokkabuild.overridePublicationArtifactId
plugins {
id("dokkabuild.kotlin-jvm")
id("dokkabuild.publish-jvm")
id("dokkabuild.test-k2")
}

overridePublicationArtifactId("all-modules-page-plugin")
Expand All @@ -29,4 30,7 @@ dependencies {
testImplementation(projects.dokkaSubprojects.pluginGfmTemplateProcessing)
testImplementation(projects.dokkaSubprojects.coreContentMatcherTestUtils)
testImplementation(projects.dokkaSubprojects.dokkaTestApi)

symbolsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-symbols", configuration = "shadow"))
descriptorsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-descriptors", configuration = "shadow"))
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 25,5 @@ dependencies {

symbolsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-symbols", configuration = "shadow"))
descriptorsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-descriptors", configuration = "shadow"))
testImplementation(projects.dokkaSubprojects.pluginBaseTestUtils) {
exclude(module = "analysis-kotlin-descriptors")
}
testImplementation(projects.dokkaSubprojects.pluginBaseTestUtils)
}
4 changes: 0 additions & 4 deletions dokka-subprojects/plugin-base-test-utils/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 17,6 @@ dependencies {

api(projects.dokkaSubprojects.analysisKotlinApi)

// TODO [beresnev] analysis switcher
//runtimeOnly(project(path = ":subprojects:analysis-kotlin-symbols", configuration = "shadow"))
runtimeOnly(project(path = ":dokka-subprojects:analysis-kotlin-descriptors", configuration = "shadow"))

implementation(kotlin("reflect"))
implementation(libs.jsoup)

Expand Down
11 changes: 2 additions & 9 deletions dokka-subprojects/plugin-base/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 37,8 @@ dependencies {
testImplementation(libs.junit.jupiterParams)

symbolsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-symbols", configuration = "shadow"))
descriptorsTestImplementation(
project(
path = ":dokka-subprojects:analysis-kotlin-descriptors",
configuration = "shadow"
)
)
testImplementation(projects.dokkaSubprojects.pluginBaseTestUtils) {
exclude(module = "analysis-kotlin-descriptors")
}
descriptorsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-descriptors", configuration = "shadow"))
testImplementation(projects.dokkaSubprojects.pluginBaseTestUtils)
testImplementation(projects.dokkaSubprojects.coreContentMatcherTestUtils)
testImplementation(projects.dokkaSubprojects.dokkaTestApi)
testImplementation(projects.dokkaSubprojects.analysisKotlinApi)
Expand Down
4 changes: 1 addition & 3 deletions dokka-subprojects/plugin-javadoc/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 27,7 @@ dependencies {
testImplementation(kotlin("test"))
symbolsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-symbols", configuration = "shadow"))
descriptorsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-descriptors", configuration = "shadow"))
testImplementation(projects.dokkaSubprojects.pluginBaseTestUtils) {
exclude(module = "analysis-kotlin-descriptors")
}
testImplementation(projects.dokkaSubprojects.pluginBaseTestUtils)
testImplementation(projects.dokkaSubprojects.dokkaTestApi)
testImplementation(libs.jsoup)
}
4 changes: 1 addition & 3 deletions dokka-subprojects/plugin-kotlin-as-java/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 25,7 @@ dependencies {
testImplementation(projects.dokkaSubprojects.pluginBase)
symbolsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-symbols", configuration = "shadow"))
descriptorsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-descriptors", configuration = "shadow"))
testImplementation(projects.dokkaSubprojects.pluginBaseTestUtils) {
exclude(module = "analysis-kotlin-descriptors")
}
testImplementation(projects.dokkaSubprojects.pluginBaseTestUtils)
testImplementation(projects.dokkaSubprojects.coreContentMatcherTestUtils)
testImplementation(projects.dokkaSubprojects.dokkaTestApi)
}
4 changes: 1 addition & 3 deletions dokka-subprojects/plugin-mathjax/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 26,5 @@ dependencies {

symbolsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-symbols", configuration = "shadow"))
descriptorsTestImplementation(project(path = ":dokka-subprojects:analysis-kotlin-descriptors", configuration = "shadow"))
testImplementation(projects.dokkaSubprojects.pluginBaseTestUtils) {
exclude(module = "analysis-kotlin-descriptors")
}
testImplementation(projects.dokkaSubprojects.pluginBaseTestUtils)
}

0 comments on commit 5a9e236

Please sign in to comment.