Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prefix): prefix based lookup feature #48

Merged
merged 12 commits into from
Nov 15, 2023
Merged

feat(prefix): prefix based lookup feature #48

merged 12 commits into from
Nov 15, 2023

Conversation

dndx
Copy link
Member

@dndx dndx commented Nov 3, 2023 •
edited by jira bot
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

Luacheck Report

9 tests   1 ✔️  0s ⏱️
1 suites  0 💤
1 files    8 ❌

For more details on these failures, see this check.

Results for commit 2eeb1ed.

♻️ This comment has been updated with latest results.

chronolaw
chronolaw reviewed Nov 7, 2023
View reviewed changes
lib/resty/lmdb/ffi.lua Outdated Show resolved Hide resolved
@dndx dndx marked this pull request as ready for review November 8, 2023 10:18
@dndx dndx changed the title [WIP] LMDB prefix based lookup feature feat(prefix): prefix based lookup feature Nov 8, 2023
@chronolaw
Copy link
Contributor

There are some lua lint warning in here,
we should fix them.

chronolaw
chronolaw reviewed Nov 13, 2023
View reviewed changes
lib/resty/lmdb.lua Outdated Show resolved Hide resolved
chobits
chobits previously approved these changes Nov 15, 2023
View reviewed changes
chronolaw
chronolaw previously approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@chronolaw chronolaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve when lua lint fix.

@dndx dndx dismissed stale reviews from chronolaw and chobits via 45767b3 November 15, 2023 03:22
@dndx dndx merged commit d236fc5 into master Nov 15, 2023
6 checks passed
@dndx dndx deleted the feat/prefix branch November 15, 2023 10:20
@chronolaw chronolaw mentioned this pull request Nov 16, 2023
Closed
3 tasks
@bungle
Copy link
Member

bungle commented Nov 16, 2023

Great feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@chobits chobits chobits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dndx @chronolaw @bungle @chobits