Fix processing of DOM nodes during the production build (minified names) #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thanks for your PR @featherbear taking a look now |
jackkav
approved these changes
Aug 30, 2023
|
@featherbear you can claim a free tshirt for this PR contribution - find more at https://konghq.com/community/open-source-contribution |
1 task
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
…es) (Kong#6419) * Fix processing of DOM nodes during the production build (minified names) * eliminate most of the typescript casting --------- Co-authored-by: jackkav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed issue #5808 where XPath queries were not working properly
Closes #5808
On the Electron release build, nodes created by
xmldomhave minified class/object/constructor names, causing thequeryXPathto return empty. This PR changes the iteration method to inspect the node'snodeType, rather than its constructor name