Paste curl modal #6384
Merged
Paste curl modal #6384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkav
force-pushed
the
fix/some-small-fixes
branch
from
8751175
to
9ab0e29
Compare
filfreire
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
@jackkav there might be a small bug when pasting some curls they are incorrectly picked up as invalid, example:
curl --request POST \
--url 'http://mockbin.org/bin/c24b72a2-1aed-48a3-be2d-b6122e855333?foo=bar&foo=baz' \
--header 'accept: application/json' \
--header 'content-type: application/x-www-form-urlencoded' \
--cookie 'foo=bar; bar=baz' \
--data foo=bar \
--data bar=baz
shows
on the bottom. But if I add a space somewhere on the curl text in the modal, it becomes valid
1 task
|
@filfreire that's correct the validation check should be happening on paste as well as change. Could you give it a try for me please? |
|
@jackkav seems the problem is the isValid and the req start as |
gatzjames
approved these changes
Aug 25, 2023
1 task
1 task
marckong
reviewed
Nov 22, 2023
|
|
||
| const handleImportQueryFromUrl = useCallback(() => { | ||
| useState(false); |
There was a problem hiding this comment.
@jackkav I am wondering if there was a reason for this?
jackkav
added a commit
to jackkav/insomnia
that referenced
this pull request
Nov 24, 2023
* remove pad left on pinned * refactor filter logic * first pass * always create new curl req * use terminal icon * fix from curl folder * wire up request create * fix paste curl in url bar * fix types * fix test * fix for initial draw isvalid check --------- Co-authored-by: Filipe Freire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Re-added a way to paste curl requests directly into URL bar.
fixes: #6338