Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move config to root directory #274

Merged
merged 2 commits into from
Sep 17, 2020
Merged

move config to root directory #274

merged 2 commits into from
Sep 17, 2020

Conversation

garak
Copy link
Contributor

@garak garak commented Sep 14, 2020

Fix #272

@garak
Copy link
Contributor Author

garak commented Sep 14, 2020

It looks like we can't remove deprecation in Symfony 5 without dropping support for Symfony 3.4
Considering that 3.4 is going to be unsupported next November, I would drop it. But I'm open to suggestions.

@alexpozzi
Copy link
Member

Hello,
For a start, thank you for the contribution.
I temporarily fix this issue setting SYMFONY_DEPRECATIONS_HELPER env var to weak (see https://github.com/KnpLabs/KnpSnappyBundle/pull/268/files#r467055035) on all the test cases but this change should be reverted as soon as we remove the support for Symfony 3.4.
I'm in favor of removing the support for Symfony 3.4, if you want I can deal with that in the coming days.

@garak
Copy link
Contributor Author

garak commented Sep 14, 2020

Thanks @alexpozzi
I was just worried about tests failing in this PR.
Do you think it's better, for now, to remove (from this PR) the change that added "utf8: true"?

@alexpozzi
Copy link
Member

Yes, I think it would be better to remove it from this PR as it's out its scope.
I'm gonna work on removing the support for Symfony 3 (and revert the CI changes I've made) later this week.

@alexpozzi
Copy link
Member

Thanks!

@alexpozzi alexpozzi merged commit 9111bc9 into KnpLabs:master Sep 17, 2020
@garak garak deleted the move-config branch September 17, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move configuration out of source directory
2 participants