Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - when the plugin is active, video sizes in discord's video player are broken, making seeing the video impossible #13

Closed
jack652 opened this issue Dec 1, 2023 · 10 comments
Assignees
Labels
bug Something isn't working resolved This problem was resolved.

Comments

@jack652
Copy link

jack652 commented Dec 1, 2023

Describe the bug:
when the plugin is active, video sizes in discord's video player are broken, making seeing the video impossible

How to reproduce:
Steps to reproduce the behaviour:

  1. go to a channel that has a video
  2. you'll notice the video's "play" icon is not centered
  3. play the video

Expected behaviour:
the video is the correct size

Screenshots:
with the plugin
image
image

without the plugin
image
image

Version of Discord:
Regular Discord 250597 (9f6f5e9)

Additional context:
Windows 11 Home 10.0.22621 Build 22621

@jack652 jack652 added the bug Something isn't working label Dec 1, 2023
@Knewest
Copy link
Owner

Knewest commented Dec 1, 2023

Hi, may you share with me which plugins your have active? Have you made sure this isn't a plugin conflict with another?

@githubguy217
Copy link

this also happens to me, its fixed instantly as soon as i disable the plugin

@Knewest
Copy link
Owner

Knewest commented Dec 3, 2023

this also happens to me, its fixed instantly as soon as i disable the plugin

Please show me the plugins you have enabled. If there is a conflict, I can look into it.

@Alluseri
Copy link

Alluseri commented Dec 3, 2023

Can reproduce.

Active plugins, besides "Uncompressed Images": none.
Discord build: Stable 250833 (84e28a2).
Plugin version: v3.20.
Important note: this ONLY happens for video attachments that have a vertical aspect ratio(h > w).
Showcase here, both cases shown where only one is affected.

@Knewest
Copy link
Owner

Knewest commented Dec 3, 2023

Can reproduce.

Active plugins, besides "Uncompressed Images": none.
Discord build: Stable 250833 (84e28a2).
Plugin version: v3.20.
Important note: this ONLY happens for video attachments that have a vertical aspect ratio(h > w).
Showcase here, both cases shown where only one is affected.

Thank you, I'll look into this. I likely noticed no issues because of having ImageUtilites enabled.

@jack652
Copy link
Author

jack652 commented Dec 3, 2023

Hi, may you share with me which plugins your have active? Have you made sure this isn't a plugin conflict with another?

only uncompressed discord images is active

Can reproduce.

Active plugins, besides "Uncompressed Images": none.
Discord build: Stable 250833 (84e28a2).
Plugin version: v3.20.
Important note: this ONLY happens for video attachments that have a vertical aspect ratio(h > w).
Showcase here, both cases shown where only one is affected.

Thank you, I'll look into this. I likely noticed no issues because of having ImageUtilites enabled.

I also had imageUtil active and the issue still happened on my end

@Knewest
Copy link
Owner

Knewest commented Dec 4, 2023

I managed to reproduce the issue, I will see what I can do about it.

@Knewest
Copy link
Owner

Knewest commented Dec 5, 2023

I have found a way to soft-patch it, but I have not tested it extensively or confirmed it causes issues. I will release that as a fix if I do not find a fix by tomorrow as I will be unavailable for the next two weeks after today. I will update this bug report with what I do.

@Knewest
Copy link
Owner

Knewest commented Dec 6, 2023

Hi, I am typing to inform you that the unavailability has been moved to next week. I have fixed this bug, but there is another bug I found that I cannot in good conscious leave unaddressed. Thanks for the patience, I will have a fix out ASAP.

@Knewest Knewest added the resolved This problem was resolved. label Dec 7, 2023
@Knewest
Copy link
Owner

Knewest commented Dec 7, 2023

Issue has been resolved in v3.21, thanks once again for reporting and confirming.

@Knewest Knewest closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved This problem was resolved.
Projects
None yet
Development

No branches or pull requests

4 participants