Merge pull request #53 from DoctorKrolic/struct-null-compare

Avoid comparing structs to `null` (use `default` instead)
KirillOsenkov · Dec 17, 2023 · 35eccf3 · 35eccf3
2 parents beb9db9 3c46046
commit 35eccf3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Microsoft.Language.Xml/Syntax/SyntaxToken.cs b/src/Microsoft.Language.Xml/Syntax/SyntaxToken.cs
@@ -1,4  1,4 @@
-using System;
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
@@ -219,9  219,9 @@ protected override int GetTextWidth()
         public override int GetSlotCountIncludingTrivia()
         {
             int triviaSlots = 0;
-            if (GetLeadingTrivia() != null)
             if (GetLeadingTrivia() != default)
                 triviaSlots  ;
-            if (GetTrailingTrivia() != null)
             if (GetTrailingTrivia() != default)
                 triviaSlots  ;
 
             return triviaSlots;

diff --git a/src/Microsoft.Language.Xml/Syntax/XmlEmptyElementSyntax.cs b/src/Microsoft.Language.Xml/Syntax/XmlEmptyElementSyntax.cs
@@ -1,4  1,4 @@
-using System;
 using System;
 using System.Collections.Generic;
 using System.Linq;
 
@@ -161,7  161,7 @@ IEnumerable<KeyValuePair<string, string>> IXmlElement.Attributes
         {
             get
             {
-                if (AttributesNode == null)
                 if (AttributesNode == default)
                 {
                     yield break;
                 }