Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature(osuValidators): added support to allow hyphened name dot number #10

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Feature(osuValidators): added support to allow hyphened name dot number #10

merged 2 commits into from
Aug 3, 2024

Conversation

KemingHe
Copy link
Owner

@KemingHe KemingHe commented Aug 3, 2024

Also improved documentation.

KemingHe added 2 commits August 3, 2024 00:07
@KemingHe
feat(osuvalidators.ts): added support for hyphened name dot number
2f82508 
names can now have hyphens, i.e. buck-eye-brutus.1. furthermore: improved readme, refactored
namespace and type exports, removed alias to preserve jsdoc

fix #7, fix #8
@KemingHe
chore(changelog): v1.1.0 via release-it (auto, ci env)
ddcc3d6
@KemingHe KemingHe added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 3, 2024
@KemingHe KemingHe self-assigned this Aug 3, 2024
@KemingHe KemingHe enabled auto-merge August 3, 2024 04:15
@codecov Codecov
Copy link

codecov bot commented Aug 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c9a8ddf) to head (ddcc3d6).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines        18787     18788    +1     
  Branches         7         7           
=========================================
+ Hits         18787     18788    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KemingHe KemingHe merged commit c526f78 into main Aug 3, 2024
15 of 26 checks passed
@KemingHe KemingHe deleted the feature-allowhyphenednames-keminghe branch August 3, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KemingHe KemingHe

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KemingHe