Implements \mathchoice command #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
edemaine
requested changes
Nov 21, 2017
test/screenshotter/ss_data.yaml
Outdated
| MathChoice: | | ||
| {\displaystyle\mathchoice{D}{T}{S}{SS}} {\textstyle\mathchoice{D}{T}{S}{SS}} {\scriptstyle \mathchoice{D}{T}{S}{SS}} {\scriptscriptstyle\mathchoice{D}{T}{S}{SS}} | ||
| MathChoice2: | | ||
| \displaystyle X_{\mathchoice{D}{T}{S}{SS}_{\mathchoice{D}{T}{S}{SS}}} |
There was a problem hiding this comment.
Can you merge these two tests (e.g. side-by-side)? I think we try to keep down the number of snapshot images, and these tests render small enough (and they're related) that it's easy to combine them.
There was a problem hiding this comment.
Sure. I've just combined them into one, and here is the result:
src/functions/mathchoice.js
Outdated
| body = group.value.script; | ||
| } else if (style === Style.SCRIPTSCRIPT) { | ||
| body = group.value.scriptscript; | ||
| } |
There was a problem hiding this comment.
Given that these lines (44-54) are repeated (25-35), perhaps it makes sense to factor them out as a shared function defined just within and for this module? Not strictly necessary, but could make for cleaner code.
There was a problem hiding this comment.
Exactly. I will define new chooseMathStyle function.
edemaine
requested changes
Nov 22, 2017
|
Oops, I forgot to remove them. Just deleted! |
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
\mathchoicefunction.I once created PR on the wrong branch. Sorry for the mess.
This is particularly useful when one defines custom macro for "big operators".
For example:
Screenshot test shows that there are still differences between LaTeX's and KaTeX's behaviour:
I think it is a problem of the current implementations of
\scriptstyleand\scriptscriptstylein KaTeX, as there is already mismatch inStyleSpacingscreenshot test: