Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve Safari rendering issues with font-size overrides. #780

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

kohler
Copy link
Collaborator

@kohler kohler commented Aug 1, 2017

Some delicate surgery is required on the vlist-s table-cell CSS.
Problem with #768 reported by @ronkok; issue #779. Fixes:

  • font-size: 1px (rather than font-size: 0.05em) solves render
    issues with user overrides of the .katex font-size.
  • Also fix a width issue.

Some delicate surgery is required on the `vlist-s` table-cell CSS.
Problem with KaTeX#768 reported by @ronkok; issue KaTeX#779. Fixes:

* `font-size: 1px` (rather than `font-size: 0.05em`) solves render
  issues with user overrides of the `.katex` `font-size`.
* Also fix a width issue.
@ronkok
Copy link
Collaborator

ronkok commented Aug 1, 2017

This looks great to me. I've checked it in Safari Mac, Safari iOS, Chrome, Firefox, Opera, IE 9-11, and Edge. Rendering looks good in all of them.

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// issues; absolute units prevent user font-size overrides from breaking
// rendering. Safari refuses to make the box zero-width, so we give it
// a known width and compensate with negative right margin on the
// inline-table.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice comment

@kevinbarabash
Copy link
Member

@kohler thanks for the quick fix. @ronkok thanks for checking the rendering in all those browsers.

@kevinbarabash kevinbarabash merged commit 766487b into KaTeX:master Aug 2, 2017
@kohler kohler deleted the fix-shrinkwrap branch August 5, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants