Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #711 issue with multiple superscripts. #718

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

kohler
Copy link
Collaborator

@kohler kohler commented Jun 6, 2017

The previous code incorrectly implemented TeXbook rules. First off,
the font metrics at issue should be those for the superscript/
subscript style, not the main style. Secondly, the metrics should be
scaled by the font size.

This changes some screenshotter tests (and they look more like TeX
now).

The previous code incorrectly implemented TeXbook rules. First off,
the font metrics at issue should be those for the superscript/
subscript style, not the main style. Secondly, the metrics should be
scaled by the font size.

This changes some screenshotter tests (and they look more like TeX
now).
@kevinbarabash kevinbarabash self-assigned this Jun 7, 2017
@kevinbarabash
Copy link
Member

Thanks for the PR. Big improvement in the vertical position of subscripts.

Before:
accents

After:
accents

Before:
binomtest

After:
binomtest

Before:
limitcontrols

After:
limitcontrols

Before:
oplimits

After:
oplimits

Before:
sqrt

After:
sqrt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants