Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space width in \texttt #1261

Merged
merged 4 commits into from
Apr 21, 2018
Merged

Fix space width in \texttt #1261

merged 4 commits into from
Apr 21, 2018

Conversation

edemaine
Copy link
Member

Fix #1255 via KaTeX/katex-fonts#41.
Also fix width metrics via KaTeX/katex-fonts#42.

@codecov
Copy link

codecov bot commented Apr 14, 2018

Codecov Report

Merging #1261 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1261    /-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files          60       60           
  Lines        3880     3880           
  Branches      651      651           
=======================================
  Hits         3199     3199           
  Misses        578      578           
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2dc1b...a85bd87. Read the comment docs.

@kevinbarabash
Copy link
Member

There must be some slight difference between ~~ in \texttt and in \verb. Can you update the screenshot?

@edemaine
Copy link
Member Author

@kevinbarabash Oops, sorry about that. Regenerated now. I think it's because I switched the test from {matrix} to {array}{l} (which I think has a better failure mode) but didn't recompile. Didn't realize it would shift the image to the right.

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this.

@kevinbarabash kevinbarabash merged commit 812b350 into KaTeX:master Apr 21, 2018
HosseinAgha pushed a commit to HosseinAgha/KaTeX that referenced this pull request Apr 23, 2018
* Fix space width in \texttt

Fix KaTeX#1255 via KaTeX/katex-fonts#41.
Also fix width metrics via KaTeX/katex-fonts#42.

* Improve test

* Update screenshots
kevinbarabash pushed a commit that referenced this pull request Apr 28, 2018
* Expose defineSymbol in the main KaTeX object

* More Unicode letters (#1260)

This PR serves as a complement to PR #1232 by supporting some letters that are omitted from the Unicode range 1D400–1D7FF.

* Include Bold-Italic fonts for \boldsymbol (#1257)

* Include Bold-Italic fonts for \boldsymbol

Fix #1228

* Update screenshots

* README: Add size badge (#1253)

* README: Add size badge

Add a size badge showing size of gzipped katex.min.js

* update-sri: Add code to replace size badge in readme

* Change to use badge from shields.io instead

My bad for assuming that badgesize.io supports https. Change to use the
badge from shields.io which supports https.

* More Unicode letters (#1260)

This PR serves as a complement to PR #1232 by supporting some letters that are omitted from the Unicode range 1D400–1D7FF.

* Include Bold-Italic fonts for \boldsymbol (#1257)

* Include Bold-Italic fonts for \boldsymbol

Fix #1228

* Update screenshots

* README: Add size badge

Add a size badge showing size of gzipped katex.min.js

* update-sri: Add code to replace size badge in readme

* Change to use badge from shields.io instead

My bad for assuming that badgesize.io supports https. Change to use the
badge from shields.io which supports https.

* Use badgesize.io with https

* Fix space width in \texttt (#1261)

* Fix space width in \texttt

Fix #1255 via KaTeX/katex-fonts#41.
Also fix width metrics via KaTeX/katex-fonts#42.

* Improve test

* Update screenshots
@ylemkimon ylemkimon mentioned this pull request Aug 18, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

\tt font blank has incorrect width
2 participants