Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio normalization #164

Open
vanarok opened this issue Aug 6, 2022 · 12 comments
Open

Audio normalization #164

vanarok opened this issue Aug 6, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@vanarok
Copy link

vanarok commented Aug 6, 2022

Is your feature request related to a problem? Please describe.
the tracks have different volume levels

Describe the solution you'd like
The same volume level

Context
https://artists.spotify.com/en/help/article/loudness-normalization

@vanarok vanarok added the enhancement New feature or request label Aug 6, 2022
@KRTirtho
Copy link
Owner

KRTirtho commented Aug 7, 2022

Nice suggestion. Although I had this in my mind fpr quite a while but didn't have much time to do so

@KRTirtho KRTirtho added this to To do in New Features via automation Aug 7, 2022
@KRTirtho
Copy link
Owner

This mpv-player/mpv#3979 (comment) & mpv.conf should resolve the issue for most linux users

KRTirtho added a commit that referenced this issue Sep 16, 2023
@KRTirtho
Copy link
Owner

It's finally done after over 1 year of wait!!!

@KRTirtho
Copy link
Owner

It's available on nightly (10 mins after this comment was posted)

@vanarok
Copy link
Author

vanarok commented Sep 17, 2023

Does the switch turn normalization on and off? Not noticeable in sound differences. I also compared the release and the night, no difference in sound.

@vanarok
Copy link
Author

vanarok commented Sep 17, 2023

Screenshot_2023-09-17-11-42-38-352_oss krtirtho spotube-edit
Screenshot_2023-09-17-11-42-19-486_oss krtirtho spotube nightly-edit

@KRTirtho
Copy link
Owner

Does the switch turn normalization on and off? Not noticeable in sound differences. I also compared the release and the night, no difference in sound.

It depends on what you're listening & you can't determine if it's working without listening to bunch of songs
It will level all the music to a certain dB depending on the volume level

@ovizii
Copy link

ovizii commented Oct 12, 2023

I'm on spotube v3.1.2 Build: 24 and can't find this feature. Can somebody please share some light where I can find it?

@KRTirtho
Copy link
Owner

This is an unreleased feature. Use the nightly version to get access to it

@Neved4
Copy link

Neved4 commented Apr 25, 2024

Hey @KRTirtho thanks for the great work 🚀
I feel this can be closed by da10ab2 and v3.2.0. Cheers! 🎉

@KRTirtho
Copy link
Owner

KRTirtho commented Apr 26, 2024

I can't close it as the dynaudnorm module of MPV ffmpeg isn't bundled with the default mpv shared library of media_kit. So Audio Normalization doesn't work on any platform except linux (in linux we use system mpv)

@KRTirtho
Copy link
Owner

I guess I've to open an issue there to see if media_kit plans to add audio normalization feature in the audio player

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Discussion
Development

No branches or pull requests

4 participants