Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompile Invalidations #951

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

xtalax
Copy link
Contributor

@xtalax xtalax commented Aug 8, 2023

Make use of PrecompileTools to recompile invalidations

@ChrisRackauckas
Copy link
Member

How much of a difference does this make?

@xtalax
Copy link
Contributor Author

xtalax commented Aug 8, 2023

Not making much difference to MOL discretization times, but that was <1% recomp anyway. What are the pathological cases this should fix?

@ChrisRackauckas
Copy link
Member

Symbolic arithmetic has some pathological cases. How much of a precompilation cost is this?

@xtalax
Copy link
Contributor Author

xtalax commented Aug 29, 2023

This adds only a few seconds to precompile time, within 3 seconds

@ChrisRackauckas
Copy link
Member

Seems like there was an issue with the merge commit. @xtalax can you start this again and I'll merge?

@xtalax xtalax closed this Sep 4, 2023
@xtalax xtalax reopened this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants