KT-8673: forEach analog which takes function with receiver for Iterable #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. We haven't yet decided on the naming of the proposed function, but should we settle on |
ilya-g
reviewed
Sep 11, 2018
| @@ -441,4 441,17 @@ object Mapping : TemplateGroupBase() { | |||
| } | |||
| } | |||
|
|
|||
| val f_withEach = fn("withEach(operation: T.() -> Unit)") { | |||
| include(Iterables) | |||
There was a problem hiding this comment.
Consider providing it for the same receivers as forEach.
Also it makes sense to make it inline same as forEach (note that different overloads have different inline modifiers)
| data.withEach { | ||
| substringList.add(substring(0, 1)) | ||
| } | ||
| assertEquals(2, substringList.size) |
There was a problem hiding this comment.
Could be just assertEquals(listOf("f", "b"), substrinList)
|
@ilya-g Thank you about feed back, now I tried to implement like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related with: https://youtrack.jetbrains.com/issue/KT-8673