Fix race condition #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Condition variables are used incorrectly in this code. If signalInitialized() is called before waiting for it, it will not be registered and the thread unnecessarily waits for 100 seconds. In addition, if the timeout expires we probably want to report this as an error but the thread instead continues to run. Using a CountDownLatch instead of Condition and ReentrantLock fixes both problems.
|
Was merged into the code base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condition variables are used incorrectly in this code.
If signalInitialized() is called before waiting for it, it will not be registered and the thread unnecessarily waits for 100 seconds.
In addition, if the timeout expires we probably want to report this as an error but the thread instead continues to run.
Using a CountDownLatch instead of Condition and ReentrantLock fixes both problems.