MPS-33490: using the 'subscript' script-kind style is non-intuitive #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maros-sandor
approved these changes
Sep 15, 2021
|
I can see the merge already got into the public MPS repo. Can you update your repo as well? I think github should then close this request as merged. It may not happen though in case it checks the destination branch is exactly 2021.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maros-sandor Thanks for the feedback. I changed the name to "super/subscript", and modified it the proper way now.
I cannot get master to work after the recent bump to 2021.2. It seems that master currently undergoes a lot of active development. To no longer delay this issue, I made the change against HEAD of 2021.1. I hope that is alright.