Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change method name 'describe' to 'createProblemDescription' #46

Closed
wants to merge 1 commit into from

Conversation

pdhung3012
Copy link

This class is used to represent GeneratorUtil. The method named 'describe' is to create a problem description. Thus, the method name 'createProblemDescription' is more intuitive than 'describe'.

@mihmuh
Copy link

mihmuh commented Aug 13, 2019

There are two more methods with similar names: describeInput, describeTemplateLocation. Their names should be changed too, at least

@mihmuh
Copy link

mihmuh commented Aug 13, 2019

@ashatalin
Copy link
Member

rejected

@ashatalin ashatalin closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants